=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2015-06-18 14:35:18 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2015-06-19 12:16:36 +0000 @@ -72,8 +72,8 @@ final String LONGITUDE_DIM_ID = "longitude"; final String LATITUDE_DIM_ID = "latitude"; - final List DATA_X_DIMS = Arrays.asList( - INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATASET_DIM_ID, DATAELEMENT_OPERAND_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID ); + final List DATA_DIMS = Arrays.asList( + INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATAELEMENT_OPERAND_ID, DATASET_DIM_ID, PROGRAM_INDICATOR_DIM_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID ); final List STATIC_DIMS = Arrays.asList( LONGITUDE_DIM_ID, LATITUDE_DIM_ID ); === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObjectUtils.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObjectUtils.java 2015-02-19 09:18:17 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObjectUtils.java 2015-06-19 12:16:36 +0000 @@ -28,7 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import static org.hisp.dhis.common.DimensionalObject.DATA_X_DIMS; +import static org.hisp.dhis.common.DimensionalObject.DATA_DIMS; import static org.hisp.dhis.common.DimensionalObject.DATA_X_DIM_ID; import java.util.ArrayList; @@ -65,7 +65,7 @@ */ public static String toDimension( String identifier ) { - if ( DATA_X_DIMS.contains( identifier ) ) + if ( DATA_DIMS.contains( identifier ) ) { return DATA_X_DIM_ID; } === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java 2015-06-18 21:47:26 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java 2015-06-19 12:16:36 +0000 @@ -47,6 +47,7 @@ import static org.hisp.dhis.common.DimensionalObject.PROGRAM_ATTRIBUTE_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.PROGRAM_DATAELEMENT_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.PROGRAM_INDICATOR_DIM_ID; +import static org.hisp.dhis.common.DimensionalObject.DATA_DIMS; import static org.hisp.dhis.common.NameableObjectUtils.asList; import static org.hisp.dhis.common.NameableObjectUtils.getList; @@ -109,8 +110,6 @@ public static final int DX_INDEX = 0; public static final int CO_IN_INDEX = 1; - public static final List DATA_DIMS = Lists.newArrayList( - INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATAELEMENT_OPERAND_ID, DATASET_DIM_ID, PROGRAM_INDICATOR_DIM_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID ); public static final List FIXED_DIMS = Lists.newArrayList( DATA_X_DIM_ID, INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATASET_DIM_ID, PROGRAM_INDICATOR_DIM_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID, PERIOD_DIM_ID, ORGUNIT_DIM_ID ); private static final List DIMENSION_PERMUTATION_IGNORE_DIMS = Lists.newArrayList( === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2015-06-18 21:47:26 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2015-06-19 12:16:36 +0000 @@ -54,6 +54,7 @@ import static org.hisp.dhis.common.DimensionalObject.PROGRAM_ATTRIBUTE_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.PROGRAM_DATAELEMENT_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.PROGRAM_INDICATOR_DIM_ID; +import static org.hisp.dhis.common.DimensionalObject.DATA_DIMS; import static org.hisp.dhis.common.DimensionalObjectUtils.toDimension; import static org.hisp.dhis.common.IdentifiableObjectUtils.getLocalPeriodIdentifier; import static org.hisp.dhis.common.IdentifiableObjectUtils.getLocalPeriodIdentifiers; @@ -1410,7 +1411,7 @@ if ( !dataElements.isEmpty() || !attributes.isEmpty() ) { - DataQueryParams dataSourceParams = params.instance().removeDimensions( DataQueryParams.DATA_DIMS ); + DataQueryParams dataSourceParams = params.instance().removeDimensions( DATA_DIMS ); dataSourceParams.getDimensions().add( DX_INDEX, new BaseDimensionalObject( PROGRAM_DATAELEMENT_DIM_ID, DimensionType.PROGRAM_DATAELEMENT, dataElements ) ); @@ -1445,7 +1446,7 @@ if ( !dataElements.isEmpty() ) { - DataQueryParams dataSourceParams = params.instance().removeDimensions( DataQueryParams.DATA_DIMS ); + DataQueryParams dataSourceParams = params.instance().removeDimensions( DATA_DIMS ); dataSourceParams.getDimensions().add( DX_INDEX, new BaseDimensionalObject( DATAELEMENT_DIM_ID, DimensionType.DATAELEMENT, dataElements ) ); @@ -1471,7 +1472,7 @@ if ( !dataElements.isEmpty() ) { - DataQueryParams dataSourceParams = params.instance().removeDimensions( DataQueryParams.DATA_DIMS ); + DataQueryParams dataSourceParams = params.instance().removeDimensions( DATA_DIMS ); dataSourceParams.getDimensions().add( DataQueryParams.DX_INDEX, new BaseDimensionalObject( DATAELEMENT_DIM_ID, DimensionType.DATAELEMENT, dataElements ) );