=== modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataApprovalController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataApprovalController.java 2015-02-17 06:00:52 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataApprovalController.java 2015-04-27 19:57:00 +0000 @@ -707,15 +707,15 @@ for ( DataSet dataSet : dataSets ) { - Set dataSetOptionCombos = dataSet.hasCategoryCombo() ? dataSet.getCategoryCombo().getOptionCombos() : null; + Set dataSetOptionCombos = dataSet.getCategoryCombo() != null ? dataSet.getCategoryCombo().getOptionCombos() : null; - for ( Period period : periods ) + for ( Approval approval : approvals.getApprovals() ) { - for ( Approval approval : approvals.getApprovals() ) + OrganisationUnit unit = organisationUnitService.getOrganisationUnit( approval.getOu() ); + DataElementCategoryOptionCombo optionCombo = categoryService.getDataElementCategoryOptionCombo( approval.getAoc() ); + + for ( Period period : periods ) { - OrganisationUnit unit = organisationUnitService.getOrganisationUnit( approval.getOu() ); - DataElementCategoryOptionCombo optionCombo = categoryService.getDataElementCategoryOptionCombo( approval.getAoc() ); - if ( dataSetOptionCombos != null && dataSetOptionCombos.contains( optionCombo ) ) { DataApproval dataApproval = new DataApproval( null, dataSet, period, unit, optionCombo, false, date, user );