=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java 2014-11-08 17:30:22 +0000 @@ -170,7 +170,7 @@ @Override public String getShortName() { - if ( getName().length() <= 50 ) + if ( getName() == null || getName().length() <= 50 ) { return getName(); } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementGroupSet.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementGroupSet.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementGroupSet.java 2014-11-08 17:30:22 +0000 @@ -211,7 +211,7 @@ @Override public String getShortName() { - if ( getName().length() <= 50 ) + if ( getName() == null || getName().length() <= 50 ) { return getName(); } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitGroupSet.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitGroupSet.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/organisationunit/OrganisationUnitGroupSet.java 2014-11-08 17:30:22 +0000 @@ -202,7 +202,7 @@ @Override public String getShortName() { - if ( getName().length() <= 50 ) + if ( getName() == null || getName().length() <= 50 ) { return getName(); } === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/user/UserController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/user/UserController.java 2014-11-07 18:23:57 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/user/UserController.java 2014-11-08 17:30:22 +0000 @@ -383,7 +383,7 @@ { UserGroup group = userGroupService.getUserGroup( ug.getUid() ); - if ( group != null && (!writeGroupRequired || securityService.canWrite( group )) ) + if ( group != null && ( !writeGroupRequired || securityService.canRead( group ) ) ) { group.addUser( user ); === modified file 'dhis-2/dhis-web/dhis-web-dashboard-integration/src/main/java/org/hisp/dhis/dashboard/usergroup/action/UpdateUserGroupAction.java' --- dhis-2/dhis-web/dhis-web-dashboard-integration/src/main/java/org/hisp/dhis/dashboard/usergroup/action/UpdateUserGroupAction.java 2014-10-16 06:17:19 +0000 +++ dhis-2/dhis-web/dhis-web-dashboard-integration/src/main/java/org/hisp/dhis/dashboard/usergroup/action/UpdateUserGroupAction.java 2014-11-08 17:30:22 +0000 @@ -134,7 +134,7 @@ User user = userService.getUser( groupMember ); userList.add( user ); - if ( writeGroupRequired && !userGroup.getMembers().contains( user) && !userService.canUpdate( user.getUserCredentials() ) ) + if ( writeGroupRequired && !userGroup.getMembers().contains( user ) && !userService.canUpdate( user.getUserCredentials() ) ) { throw new UpdateAccessDeniedException( "You don't have permission to add all selected users to this group" ); }