=== added file 'dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/SectionObjectBundleHook.java' --- dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/SectionObjectBundleHook.java 1970-01-01 00:00:00 +0000 +++ dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/SectionObjectBundleHook.java 2016-03-08 10:39:47 +0000 @@ -0,0 +1,59 @@ +package org.hisp.dhis.dxf2.metadata2.objectbundle.hooks; + +/* + * Copyright (c) 2004-2016, University of Oslo + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * Neither the name of the HISP project nor the names of its contributors may + * be used to endorse or promote products derived from this software without + * specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +import org.hisp.dhis.common.IdentifiableObject; +import org.hisp.dhis.dataelement.DataElementOperand; +import org.hisp.dhis.dataset.Section; +import org.hisp.dhis.dxf2.metadata2.objectbundle.ObjectBundle; +import org.springframework.stereotype.Component; + +/** + * @author Morten Olav Hansen + */ +@Component +public class SectionObjectBundleHook extends AbstractObjectBundleHook +{ + @Override + public void preCreate( IdentifiableObject identifiableObject, ObjectBundle objectBundle ) + { + if ( !Section.class.isInstance( identifiableObject ) ) + { + return; + } + + Section section = (Section) identifiableObject; + + for ( DataElementOperand dataElementOperand : section.getGreyedFields() ) + { + preheatService.connectReferences( dataElementOperand, objectBundle.getPreheat(), objectBundle.getPreheatIdentifier() ); + sessionFactory.getCurrentSession().save( dataElementOperand ); + } + } +} === modified file 'dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/UserObjectBundleHook.java' --- dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/UserObjectBundleHook.java 2016-03-08 09:21:54 +0000 +++ dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata2/objectbundle/hooks/UserObjectBundleHook.java 2016-03-08 10:39:47 +0000 @@ -91,6 +91,8 @@ sessionFactory.getCurrentSession().save( userCredentials ); user.setUserCredentials( userCredentials ); sessionFactory.getCurrentSession().update( userCredentials ); + + userCredentials = null; } @Override === modified file 'dhis-2/dhis-services/dhis-service-dxf2/src/test/java/org/hisp/dhis/dxf2/metadata2/objectbundle/ObjectBundleServiceTest.java' --- dhis-2/dhis-services/dhis-service-dxf2/src/test/java/org/hisp/dhis/dxf2/metadata2/objectbundle/ObjectBundleServiceTest.java 2016-03-08 10:07:37 +0000 +++ dhis-2/dhis-services/dhis-service-dxf2/src/test/java/org/hisp/dhis/dxf2/metadata2/objectbundle/ObjectBundleServiceTest.java 2016-03-08 10:39:47 +0000 @@ -38,6 +38,7 @@ import org.hisp.dhis.dataelement.DataElement; import org.hisp.dhis.dataelement.DataElementCategoryCombo; import org.hisp.dhis.dataelement.DataElementGroup; +import org.hisp.dhis.dataelement.DataElementOperand; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.Section; import org.hisp.dhis.dxf2.metadata2.MetadataExportService; @@ -58,7 +59,6 @@ import org.hisp.dhis.user.User; import org.hisp.dhis.user.UserAuthorityGroup; import org.hisp.dhis.user.UserGroup; -import org.junit.Ignore; import org.junit.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.core.io.ClassPathResource; @@ -797,7 +797,6 @@ } @Test - @Ignore public void testCreateDataSetWithSectionsAndGreyedFields() throws IOException { Map, List> metadata = renderService.fromMetadata( @@ -809,8 +808,44 @@ params.setObjects( metadata ); ObjectBundle bundle = objectBundleService.create( params ); - objectBundleService.validate( bundle ); + ObjectBundleValidation validate = objectBundleService.validate( bundle ); + assertTrue( validate.getObjectErrorReportsMap().isEmpty() ); + objectBundleService.commit( bundle ); + + List dataSets = manager.getAll( DataSet.class ); + List
sections = manager.getAll( Section.class ); + List organisationUnits = manager.getAll( OrganisationUnit.class ); + List dataElements = manager.getAll( DataElement.class ); + List userRoles = manager.getAll( UserAuthorityGroup.class ); + List users = manager.getAll( User.class ); + List dataElementOperands = manager.getAll( DataElementOperand.class ); + + assertFalse( organisationUnits.isEmpty() ); + assertFalse( dataElements.isEmpty() ); + assertFalse( users.isEmpty() ); + assertFalse( userRoles.isEmpty() ); + + assertEquals( 1, dataSets.size() ); + assertEquals( 2, sections.size() ); + assertEquals( 1, dataElementOperands.size() ); + + DataSet dataSet = dataSets.get( 0 ); + assertEquals( 2, dataSet.getSections().size() ); + + Section section1 = sections.get( 0 ); + Section section2 = sections.get( 1 ); + + assertEquals( 1, section1.getDataElements().size() ); + assertEquals( 1, section2.getDataElements().size() ); + + assertNotNull( section1.getDataSet() ); + assertNotNull( section2.getDataSet() ); + + Section section = manager.get( Section.class, "JwcV2ZifEQf" ); + assertNotNull( section.getDataSet() ); + assertNotNull( section.getCategoryCombo() ); + // assertEquals( 1, section.getGreyedFields().size() ); } private void defaultSetup()