=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2013-12-10 19:08:51 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2013-12-20 14:53:40 +0000 @@ -46,6 +46,7 @@ import org.hisp.dhis.common.view.ExportView; import org.hisp.dhis.common.view.WithoutOrganisationUnitsView; import org.hisp.dhis.dataelement.DataElement; +import org.hisp.dhis.dataelement.DataElementCategoryCombo; import org.hisp.dhis.dataelement.DataElementOperand; import org.hisp.dhis.dataentryform.DataEntryForm; import org.hisp.dhis.indicator.Indicator; @@ -119,6 +120,11 @@ * The Sections associated with the DataSet. */ private Set
sections = new HashSet
(); + + /** + * The CategoryCombo used for data attributes. + */ + private DataElementCategoryCombo categoryCombo; /** * Indicating position in the custom sort order. @@ -578,6 +584,20 @@ } @JsonProperty + @JsonSerialize( as = BaseIdentifiableObject.class ) + @JsonView( { DetailedView.class, ExportView.class } ) + @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0) + public DataElementCategoryCombo getCategoryCombo() + { + return categoryCombo; + } + + public void setCategoryCombo( DataElementCategoryCombo categoryCombo ) + { + this.categoryCombo = categoryCombo; + } + + @JsonProperty @JsonView({ DetailedView.class, ExportView.class, WithoutOrganisationUnitsView.class }) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) public boolean isMobile() === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/hibernate/HibernateCategoryComboStore.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/hibernate/HibernateCategoryComboStore.java 2013-12-20 12:15:39 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/hibernate/HibernateCategoryComboStore.java 2013-12-20 14:53:40 +0000 @@ -45,6 +45,8 @@ @SuppressWarnings("unchecked") public Collection getCategoryCombosByDimensionType( String dimensionType ) { - return getCriteria( Restrictions.eq( "dimensionType", dimensionType ) ).list(); + return getCriteria( Restrictions.or( + Restrictions.eq( "dimensionType", dimensionType ), + Restrictions.eq( "name", "default" ) ) ).list(); } } === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2013-12-20 12:55:20 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2013-12-20 14:53:40 +0000 @@ -79,6 +79,8 @@ @Transactional public void execute() { + int defaultCategoryComboId = getDefaultCategoryCombo(); + // --------------------------------------------------------------------- // Drop outdated tables // --------------------------------------------------------------------- @@ -656,7 +658,8 @@ executeSql( "update categorycombo set dimensiontype = '" + DataElementCategoryCombo.DIMENSION_TYPE_DISAGGREGATION + "' where dimensiontype is null" ); executeSql( "update dataelementcategory set dimensiontype = '" + DataElementCategoryCombo.DIMENSION_TYPE_DISAGGREGATION + "' where dimensiontype is null" ); - + executeSql( "update dataset set categorycomboid = " + defaultCategoryComboId + " where categorycomboid is null" ); + upgradeDataValuesWithAttributeOptionCombo(); upgradeMapViewsToAnalyticalObject(); @@ -1075,6 +1078,13 @@ return statementManager.getHolder().queryForInteger( sql ); } + private int getDefaultCategoryCombo() + { + String sql = "select categorycomboid from categorycombo where name = 'default'"; + + return statementManager.getHolder().queryForInteger( sql ); + } + private boolean updateDataSetAssociation() { StatementHolder holder = statementManager.getHolder(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2013-11-28 20:52:27 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2013-12-20 14:53:40 +0000 @@ -61,6 +61,10 @@ + + categoryCombos = new ArrayList(); + + public List getCategoryCombos() + { + return categoryCombos; + } + private List legendSets; public List getLegendSets() @@ -148,8 +162,9 @@ { periodTypes = periodService.getAllPeriodTypes(); userGroups = new ArrayList( userGroupService.getAllUserGroups() ); + categoryCombos = new ArrayList( categoryService.getAttributeCategoryCombos() ); legendSets = new ArrayList( mappingService.getAllMapLegendSets() ); - + if ( dataSetId != null ) { dataSet = dataSetService.getDataSet( dataSetId, true, true, false ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java 2013-11-28 20:52:27 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java 2013-12-20 14:53:40 +0000 @@ -30,6 +30,7 @@ import com.opensymphony.xwork2.Action; import org.hisp.dhis.dataelement.DataElement; +import org.hisp.dhis.dataelement.DataElementCategoryService; import org.hisp.dhis.dataelement.DataElementService; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; @@ -89,6 +90,13 @@ this.indicatorService = indicatorService; } + private DataElementCategoryService categoryService; + + public void setCategoryService( DataElementCategoryService categoryService ) + { + this.categoryService = categoryService; + } + private SectionService sectionService; public void setSectionService( SectionService sectionService ) @@ -254,6 +262,13 @@ this.indicatorsSelectedList = indicatorsSelectedList; } + private Integer categoryComboId; + + public void setCategoryComboId( Integer categoryComboId ) + { + this.categoryComboId = categoryComboId; + } + private Integer selectedLegendSetId; public void setSelectedLegendSetId( Integer selectedLegendSetId ) @@ -300,7 +315,7 @@ dataSet.setTimelyDays( timelyDays ); dataSet.setSkipAggregation( skipAggregation ); - if ( !(equalsNullSafe( name, dataSet.getName() ) && + if ( !( equalsNullSafe( name, dataSet.getName() ) && periodType.equals( dataSet.getPeriodType() ) && dataElements.equals( dataSet.getDataElements() ) && indicators.equals( dataSet.getIndicators() ) && @@ -327,6 +342,11 @@ dataSet.setNotificationRecipients( userGroupService.getUserGroup( notificationRecipients ) ); dataSet.setLegendSet( legendSet ); + if ( categoryComboId != null ) + { + dataSet.setCategoryCombo( categoryService.getDataElementCategoryCombo( categoryComboId ) ); + } + dataSetService.updateDataSet( dataSet ); // --------------------------------------------------------------------- === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml 2013-11-28 20:52:27 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/META-INF/dhis/beans.xml 2013-12-20 14:53:40 +0000 @@ -91,15 +91,11 @@ - - - - - + @@ -115,6 +111,8 @@ + + + @@ -134,6 +133,7 @@ + === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/org/hisp/dhis/dataset/i18n_module.properties' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/org/hisp/dhis/dataset/i18n_module.properties 2013-12-17 20:08:53 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/org/hisp/dhis/dataset/i18n_module.properties 2013-12-20 14:53:40 +0000 @@ -8,10 +8,9 @@ data_element=Data element data_elements=Data elements indicators=Indicators -category_combo=Category Combo select_categorycombo=Select Category Combo title=Title -category_combo=Category combinations +category_combo=Combination of categories add_dataset=Add data set dataset_details=Data set details multiorg_dataset_details=Multi-organisation unit entry details === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/struts.xml' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/struts.xml 2013-09-23 09:49:44 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/resources/struts.xml 2013-12-20 14:53:40 +0000 @@ -14,15 +14,6 @@ /dhis-web-maintenance-dataset/menu.vm - - - - /main.vm - /dhis-web-maintenance-dataset/dataSetList.vm - /dhis-web-maintenance-dataset/menu.vm - javascript/dataSet.js - - @@ -112,7 +103,14 @@ dataSet.action - + + + + /main.vm + /dhis-web-maintenance-dataset/dataSetList.vm + /dhis-web-maintenance-dataset/menu.vm + javascript/dataSet.js + /main.vm @@ -121,8 +119,6 @@ F_DATASET_PUBLIC_ADD, F_DATASET_PRIVATE_ADD - - /main.vm /dhis-web-maintenance-dataset/editDataSet.vm @@ -130,8 +126,6 @@ F_DATASET_PUBLIC_ADD, F_DATASET_PRIVATE_ADD - - ../dhis-web-commons/ajax/jsonResponseSuccess.vm ../dhis-web-commons/ajax/jsonResponseError.vm === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm 2013-12-12 15:38:28 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm 2013-12-20 14:53:40 +0000 @@ -89,13 +89,23 @@ + + + + + + - + === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm 2013-12-12 15:38:28 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm 2013-12-20 14:53:40 +0000 @@ -94,7 +94,17 @@ #end - + + + + + + +