=== modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java 2015-06-17 14:52:34 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/DataQueryParams.java 2015-06-18 06:21:45 +0000 @@ -106,7 +106,7 @@ public static final String DISPLAY_NAME_LONGITUDE = "Longitude"; public static final String DISPLAY_NAME_LATITUDE = "Latitude"; - public static final int DE_IN_INDEX = 0; + public static final int DX_INDEX = 0; public static final int CO_IN_INDEX = 1; public static final List DATA_DIMS = Arrays.asList( @@ -506,15 +506,7 @@ return this; } - - /** - * Returns the index of the indicator dimension in the dimension map. - */ - public int getIndicatorDimensionIndex() - { - return getDimensionIdentifiersAsList().indexOf( INDICATOR_DIM_ID ); - } - + /** * Returns the index of the data element dimension in the dimension map. */ @@ -1029,12 +1021,12 @@ { List keys = new ArrayList<>( Arrays.asList( key.split( DIMENSION_SEP ) ) ); - String de = keys.get( DE_IN_INDEX ); + String de = keys.get( DX_INDEX ); String coc = cocEnabled ? keys.get( CO_IN_INDEX ) : null; DataElementOperand operand = new DataElementOperand( de, coc ); - ListUtils.removeAll( keys, DE_IN_INDEX, ( cocEnabled ? CO_IN_INDEX : -1 ) ); + ListUtils.removeAll( keys, DX_INDEX, ( cocEnabled ? CO_IN_INDEX : -1 ) ); String permKey = StringUtils.join( keys, DIMENSION_SEP ); === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2015-06-18 06:03:40 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2015-06-18 06:21:45 +0000 @@ -41,6 +41,7 @@ import static org.hisp.dhis.analytics.DataQueryParams.DISPLAY_NAME_PROGRAM_INDICATOR; import static org.hisp.dhis.analytics.DataQueryParams.KEY_DE_GROUP; import static org.hisp.dhis.analytics.DataQueryParams.COMPLETENESS_DIMENSION_TYPES; +import static org.hisp.dhis.analytics.DataQueryParams.DX_INDEX; import static org.hisp.dhis.common.DimensionalObject.CATEGORYOPTIONCOMBO_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.DATAELEMENT_DIM_ID; import static org.hisp.dhis.common.DimensionalObject.DATASET_DIM_ID; @@ -302,8 +303,6 @@ dataSourceParams.removeDimension( PROGRAM_DATAELEMENT_DIM_ID ); dataSourceParams.removeDimension( PROGRAM_ATTRIBUTE_DIM_ID ); - int indicatorIndex = dataSourceParams.getIndicatorDimensionIndex(); - List indicators = asTypedList( dataSourceParams.getIndicators() ); Period filterPeriod = dataSourceParams.getFilterPeriod(); @@ -347,7 +346,7 @@ { List row = new ArrayList<>( dimensionItems ); - row.add( indicatorIndex, new DimensionItem( INDICATOR_DIM_ID, indicator ) ); + row.add( DX_INDEX, new DimensionItem( INDICATOR_DIM_ID, indicator ) ); Double roundedValue = indicator.hasDecimals() ? MathUtils.getRounded( value, indicator.getDecimals() ) : MathUtils.getRounded( value ); @@ -1355,7 +1354,7 @@ DataQueryParams dataSourceParams = params.instance().removeDimensions( INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATASET_DIM_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID ); - dataSourceParams.getDimensions().add( DataQueryParams.DE_IN_INDEX, new BaseDimensionalObject( + dataSourceParams.getDimensions().add( DataQueryParams.DX_INDEX, new BaseDimensionalObject( DATAELEMENT_DIM_ID, DimensionType.DATAELEMENT, dataElements ) ); return getAggregatedDataValueMap( dataSourceParams ); @@ -1382,7 +1381,7 @@ DataQueryParams dataSourceParams = params.instance().removeDimensions( INDICATOR_DIM_ID, DATAELEMENT_DIM_ID, DATASET_DIM_ID, PROGRAM_DATAELEMENT_DIM_ID, PROGRAM_ATTRIBUTE_DIM_ID ); - dataSourceParams.getDimensions().add( DataQueryParams.DE_IN_INDEX, new BaseDimensionalObject( + dataSourceParams.getDimensions().add( DataQueryParams.DX_INDEX, new BaseDimensionalObject( DATAELEMENT_DIM_ID, DimensionType.DATAELEMENT, dataElements ) ); dataSourceParams.getDimensions().add( DataQueryParams.CO_IN_INDEX, new BaseDimensionalObject( CATEGORYOPTIONCOMBO_DIM_ID, DimensionType.CATEGORY_OPTION_COMBO, new ArrayList() ) );