=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java 2015-02-05 06:53:38 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java 2015-02-25 17:10:19 +0000 @@ -35,7 +35,9 @@ import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper; import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty; import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; + import org.hisp.dhis.common.view.DimensionalView; +import org.hisp.dhis.legend.LegendSet; import java.util.ArrayList; import java.util.Arrays; @@ -63,6 +65,11 @@ private List items = new ArrayList<>(); /** + * The legend set for this dimension. + */ + protected LegendSet legendSet; + + /** * Filter. Applicable for events. Contains operator and filter on this format: * :;: * Operator and filter pairs can be repeated any number of times. @@ -219,6 +226,22 @@ @Override @JsonProperty + @JsonSerialize( as = BaseIdentifiableObject.class ) + @JsonDeserialize( as = BaseIdentifiableObject.class ) + @JsonView( { DimensionalView.class } ) + @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) + public LegendSet getLegendSet() + { + return legendSet; + } + + public void setLegendSet( LegendSet legendSet ) + { + this.legendSet = legendSet; + } + + @Override + @JsonProperty @JsonView( { DimensionalView.class } ) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) public String getFilter() @@ -248,12 +271,14 @@ { dimensionType = dimensionalObject.getDimensionType(); dimensionName = dimensionalObject.getDimensionName(); + legendSet = dimensionalObject.getLegendSet(); filter = dimensionalObject.getFilter(); } else if ( MergeStrategy.MERGE_IF_NOT_NULL.equals( strategy ) ) { dimensionType = dimensionalObject.getDimensionType() == null ? dimensionType : dimensionalObject.getDimensionType(); dimensionName = dimensionalObject.getDimensionName() == null ? dimensionName : dimensionalObject.getDimensionName(); + legendSet = dimensionalObject.getLegendSet() == null ? legendSet : dimensionalObject.getLegendSet(); filter = dimensionalObject.getFilter() == null ? filter : dimensionalObject.getFilter(); } @@ -265,6 +290,6 @@ @Override public String toString() { - return "[" + uid + ", type: " + dimensionType + ", items: " + items + ", filter: " + filter + "]"; + return "[" + uid + ", type: " + dimensionType + ", items: " + items + ", legend set: " + legendSet + ", filter: " + filter + "]"; } } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2015-02-25 17:10:19 +0000 @@ -37,6 +37,7 @@ import org.hisp.dhis.dataelement.DataElement; import org.hisp.dhis.dataelement.DataElementCategory; import org.hisp.dhis.dataelement.DataElementGroupSet; +import org.hisp.dhis.legend.LegendSet; import org.hisp.dhis.organisationunit.OrganisationUnitGroupSet; import org.hisp.dhis.trackedentity.TrackedEntityAttribute; @@ -117,6 +118,11 @@ boolean hasItems(); /** + * Gets the legend set. + */ + LegendSet getLegendSet(); + + /** * Gets the filter. Contains operator and filter. Applicable for events. */ String getFilter(); === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java 2015-02-24 13:57:25 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java 2015-02-25 17:10:19 +0000 @@ -47,7 +47,6 @@ import org.hisp.dhis.common.view.ExportView; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.comparator.DataSetFrequencyComparator; -import org.hisp.dhis.legend.LegendSet; import org.hisp.dhis.option.OptionSet; import org.hisp.dhis.period.PeriodType; import org.hisp.dhis.period.YearlyPeriodType; @@ -198,11 +197,6 @@ */ private OptionSet commentOptionSet; - /** - * The legend set for this data element. - */ - private LegendSet legendSet; - // ------------------------------------------------------------------------- // Constructors // ------------------------------------------------------------------------- @@ -724,20 +718,6 @@ this.commentOptionSet = commentOptionSet; } - @JsonProperty - @JsonSerialize( as = BaseIdentifiableObject.class ) - @JsonView( { DetailedView.class, ExportView.class } ) - @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) - public LegendSet getLegendSet() - { - return legendSet; - } - - public void setLegendSet( LegendSet legendSet ) - { - this.legendSet = legendSet; - } - @Override public void mergeWith( IdentifiableObject other, MergeStrategy strategy ) { === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/trackedentity/TrackedEntityAttribute.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/trackedentity/TrackedEntityAttribute.java 2015-02-24 23:41:01 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/trackedentity/TrackedEntityAttribute.java 2015-02-25 17:10:19 +0000 @@ -28,12 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import com.fasterxml.jackson.annotation.JsonProperty; -import com.fasterxml.jackson.annotation.JsonView; -import com.fasterxml.jackson.databind.annotation.JsonSerialize; -import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty; -import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; - import org.hisp.dhis.common.BaseDimensionalObject; import org.hisp.dhis.common.BaseIdentifiableObject; import org.hisp.dhis.common.DxfNamespaces; @@ -42,11 +36,16 @@ import org.hisp.dhis.common.view.DetailedView; import org.hisp.dhis.common.view.ExportView; import org.hisp.dhis.common.view.WithoutOrganisationUnitsView; -import org.hisp.dhis.legend.LegendSet; import org.hisp.dhis.option.Option; import org.hisp.dhis.option.OptionSet; import org.hisp.dhis.schema.annotation.PropertyRange; +import com.fasterxml.jackson.annotation.JsonProperty; +import com.fasterxml.jackson.annotation.JsonView; +import com.fasterxml.jackson.databind.annotation.JsonSerialize; +import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty; +import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; + /** * @author Abyot Asalefew */ @@ -76,8 +75,6 @@ private OptionSet optionSet; - private LegendSet legendSet; - private String expression; private Boolean displayOnVisitSchedule = false; @@ -340,20 +337,6 @@ } @JsonProperty - @JsonSerialize( as = BaseIdentifiableObject.class ) - @JsonView( { DetailedView.class, ExportView.class } ) - @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) - public LegendSet getLegendSet() - { - return legendSet; - } - - public void setLegendSet( LegendSet legendSet ) - { - this.legendSet = legendSet; - } - - @JsonProperty @JsonView( { DetailedView.class, ExportView.class } ) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) public Boolean getConfidential()