=== modified file 'dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/javascripts/dhis2/dhis2.selected.js' --- dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/javascripts/dhis2/dhis2.selected.js 2014-04-07 02:58:35 +0000 +++ dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/dhis-web-commons/javascripts/dhis2/dhis2.selected.js 2014-04-07 07:19:13 +0000 @@ -7,40 +7,40 @@ !(function( $, window, document, undefined ) { var methods = { create: function( options ) { - var settings = {}; - $.extend(settings, $.fn.selected.defaults, options); + var context = {}; + $.extend(context, $.fn.selected.defaults, options); - if( settings.target === undefined ) { + if( context.target === undefined ) { $.error('selected: Missing options.target, please add your target box either as a jqEl or as a query.'); - } else if( settings.url === undefined ) { + } else if( context.url === undefined ) { $.error('selected: Missing options.url, please give URL of where to find the source data.'); - } else if( !$.isFunction(settings.handler) ) { + } else if( !$.isFunction(context.handler) ) { $.error('selected: Invalid options.handler.'); } // pass-through if jqEl, query if string - settings.source = this; - settings.target = $(settings.target); - settings.search = $(settings.search); + context.source = this; + context.target = $(context.target); + context.search = $(context.search); - if( !(settings.source instanceof $) ) { + if( !(context.source instanceof $) ) { $.error('selected: Invalid source.'); - } else if( !(settings.target instanceof $) ) { + } else if( !(context.target instanceof $) ) { $.error('selected: Invalid target.'); } - settings.source.data('selected', settings); - settings.target.data('selected', settings); - - settings.page = 1; - settings.defaultProgressiveLoader(settings); - - settings.source.on('dblclick', 'option', settings.defaultSourceDblClickHandler); - settings.target.on('dblclick', 'option', settings.defaultTargetDblClickHandler); - settings.source.on('scroll', settings.makeScrollHandler(settings)); - - if( settings.search instanceof $ ) { - settings.search.on('keypress', settings.makeSearchHandler(settings)); + context.source.data('selected', context); + context.target.data('selected', context); + + context.page = 1; + context.defaultProgressiveLoader(context); + + context.source.on('dblclick', 'option', context.defaultSourceDblClickHandler); + context.target.on('dblclick', 'option', context.defaultTargetDblClickHandler); + context.source.on('scroll', context.makeScrollHandler(context)); + + if( context.search instanceof $ ) { + context.search.on('keypress', context.makeSearchHandler(context)); } } }; @@ -93,62 +93,64 @@ $this.removeAttr('selected'); $selected.source.append($this); }, - makeSearchHandler: function( settings ) { + makeSearchHandler: function( context ) { return function( e ) { if( e.keyCode == 13 ) { - settings.defaultProgressiveLoader(settings, $(this).val()); + context.page = 1; + context.like = $(this).val(); + context.defaultProgressiveLoader(context); e.preventDefault(); } } }, - makeScrollHandler: function( settings ) { + makeScrollHandler: function( context ) { return function( e ) { - if( settings.source[0].offsetHeight + settings.source.scrollTop() >= settings.source[0].scrollHeight ) { - settings.defaultProgressiveLoader(settings); + if( context.source[0].offsetHeight + context.source.scrollTop() >= context.source[0].scrollHeight ) { + context.defaultProgressiveLoader(context); } } }, - defaultProgressiveLoader: function( settings, search ) { - if( settings.page === undefined ) { + defaultProgressiveLoader: function( context ) { + if( context.page === undefined ) { return; } var request = { - url: settings.url, + url: context.url, data: { paging: true, pageSize: 50, - page: settings.page + page: context.page }, dataType: 'json' }; - if( search !== undefined && search.length > 0 ) { - request.data.filter = 'name:like:' + search; + if( context.like !== undefined && context.like.length > 0 ) { + request.data.filter = 'name:like:' + context.like; } return $.ajax(request).done(function( data ) { if( data.pager.page == 1 ) { - settings.source.children().remove(); - } - - settings.page++; - - if( settings.page > data.pager.pageCount ) { - delete settings.page; - } - - if( data[settings.iterator] === undefined ) { - $.error('selected: Invalid iterator for source url: ' + settings.iterator); - } - - $.each(data[settings.iterator], function( idx ) { - if( settings.target.find('option[value=' + this.id + ']').length == 0 ) { - settings.source.append(settings.handler(this)); + context.source.children().remove(); + } + + context.page++; + + if( context.page > data.pager.pageCount ) { + delete context.page; + } + + if( data[context.iterator] === undefined ) { + $.error('selected: Invalid iterator for source url: ' + context.iterator); + } + + $.each(data[context.iterator], function( idx ) { + if( context.target.find('option[value=' + this.id + ']').length == 0 ) { + context.source.append(context.handler(this)); } }); }).fail(function() { - settings.source.children().remove(); + context.source.children().remove(); }); } }; === modified file 'dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/macros.vm' --- dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/macros.vm 2014-04-06 12:57:33 +0000 +++ dhis-2/dhis-web/dhis-web-commons-resources/src/main/webapp/macros.vm 2014-04-07 07:19:13 +0000 @@ -438,7 +438,7 @@ - + === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/AddDataSetAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/AddDataSetAction.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/AddDataSetAction.java 2014-04-07 07:19:13 +0000 @@ -28,8 +28,8 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.google.common.collect.Lists; import com.opensymphony.xwork2.Action; - import org.hisp.dhis.attribute.AttributeService; import org.hisp.dhis.dataelement.DataElementCategoryService; import org.hisp.dhis.dataelement.DataElementService; @@ -44,7 +44,6 @@ import org.hisp.dhis.user.UserGroupService; import org.hisp.dhis.user.UserService; -import java.util.Collection; import java.util.HashSet; import java.util.List; import java.util.Set; @@ -53,7 +52,6 @@ /** * @author Kristian - * @version $Id: AddDataSetAction.java 6255 2008-11-10 16:01:24Z larshelg $ */ public class AddDataSetAction implements Action @@ -82,7 +80,7 @@ { this.indicatorService = indicatorService; } - + private DataElementCategoryService categoryService; public void setCategoryService( DataElementCategoryService categoryService ) @@ -219,9 +217,9 @@ { this.validCompleteOnly = validCompleteOnly; } - + private boolean noValueRequiresComment; - + public void setNoValueRequiresComment( boolean noValueRequiresComment ) { this.noValueRequiresComment = noValueRequiresComment; @@ -255,22 +253,22 @@ this.renderHorizontally = renderHorizontally; } - private Collection dataElementsSelectedList = new HashSet(); + private List deSelected = Lists.newArrayList(); - public void setDataElementsSelectedList( Collection dataElementsSelectedList ) + public void setDeSelected( List deSelected ) { - this.dataElementsSelectedList = dataElementsSelectedList; + this.deSelected = deSelected; } - private Collection indicatorsSelectedList = new HashSet(); + private List inSelected = Lists.newArrayList(); - public void setIndicatorsSelectedList( Collection indicatorsSelectedList ) + public void setInSelected( List inSelected ) { - this.indicatorsSelectedList = indicatorsSelectedList; + this.inSelected = inSelected; } private Integer categoryComboId; - + public void setCategoryComboId( Integer categoryComboId ) { this.categoryComboId = categoryComboId; @@ -315,23 +313,23 @@ dataSet.setTimelyDays( timelyDays ); dataSet.setSkipAggregation( skipAggregation ); - for ( String id : dataElementsSelectedList ) + for ( String id : deSelected ) { - dataSet.addDataElement( dataElementService.getDataElement( Integer.parseInt( id ) ) ); + dataSet.addDataElement( dataElementService.getDataElement( id ) ); } Set indicators = new HashSet(); - for ( String id : indicatorsSelectedList ) + for ( String id : inSelected ) { - indicators.add( indicatorService.getIndicator( Integer.parseInt( id ) ) ); + indicators.add( indicatorService.getIndicator( id ) ); } if ( categoryComboId != null ) { dataSet.setCategoryCombo( categoryService.getDataElementCategoryCombo( categoryComboId ) ); } - + dataSet.setDescription( description ); dataSet.setVersion( 1 ); dataSet.setMobile( false ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/UpdateDataSetAction.java 2014-04-07 07:19:13 +0000 @@ -28,6 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.google.common.collect.Lists; import com.opensymphony.xwork2.Action; import org.hisp.dhis.attribute.AttributeService; import org.hisp.dhis.dataelement.DataElement; @@ -46,7 +47,6 @@ import org.hisp.dhis.system.util.AttributeUtils; import org.hisp.dhis.user.UserGroupService; -import java.util.Collection; import java.util.HashSet; import java.util.List; import java.util.Set; @@ -56,7 +56,6 @@ /** * @author Kristian - * @version $Id: UpdateDataSetAction.java 6255 2008-11-10 16:01:24Z larshelg $ */ public class UpdateDataSetAction implements Action @@ -238,7 +237,7 @@ } private boolean noValueRequiresComment; - + public void setNoValueRequiresComment( boolean noValueRequiresComment ) { this.noValueRequiresComment = noValueRequiresComment; @@ -272,22 +271,22 @@ this.renderHorizontally = renderHorizontally; } - private Collection dataElementsSelectedList = new HashSet(); + private List deSelected = Lists.newArrayList(); - public void setDataElementsSelectedList( Collection dataElementsSelectedList ) + public void setDeSelected( List deSelected ) { - this.dataElementsSelectedList = dataElementsSelectedList; + this.deSelected = deSelected; } - private Collection indicatorsSelectedList = new HashSet(); + private List inSelected = Lists.newArrayList(); - public void setIndicatorsSelectedList( Collection indicatorsSelectedList ) + public void setInSelected( List inSelected ) { - this.indicatorsSelectedList = indicatorsSelectedList; + this.inSelected = inSelected; } private Integer categoryComboId; - + public void setCategoryComboId( Integer categoryComboId ) { this.categoryComboId = categoryComboId; @@ -326,16 +325,16 @@ MapLegendSet legendSet = mappingService.getMapLegendSet( selectedLegendSetId ); - for ( String id : dataElementsSelectedList ) + for ( String id : deSelected ) { - dataElements.add( dataElementService.getDataElement( Integer.parseInt( id ) ) ); + dataElements.add( dataElementService.getDataElement( id ) ); } Set indicators = new HashSet(); - for ( String id : indicatorsSelectedList ) + for ( String id : inSelected ) { - indicators.add( indicatorService.getIndicator( Integer.parseInt( id ) ) ); + indicators.add( indicatorService.getIndicator( id ) ); } PeriodType periodType = periodService.getPeriodTypeByName( frequencySelect ); @@ -346,7 +345,7 @@ dataSet.setTimelyDays( timelyDays ); dataSet.setSkipAggregation( skipAggregation ); - if ( !( equalsNullSafe( name, dataSet.getName() ) && + if ( !(equalsNullSafe( name, dataSet.getName() ) && periodType.equals( dataSet.getPeriodType() ) && dataElements.equals( dataSet.getDataElements() ) && indicators.equals( dataSet.getIndicators() ) && @@ -379,7 +378,7 @@ { dataSet.setCategoryCombo( categoryService.getDataElementCategoryCombo( categoryComboId ) ); } - + if ( jsonAttributeValues != null ) { AttributeUtils.updateAttributeValuesFromJson( dataSet.getAttributeValues(), jsonAttributeValues, === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm 2014-01-23 11:54:46 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/addDataSet.vm 2014-04-07 07:19:13 +0000 @@ -1,62 +1,34 @@

$i18n.getString( "add_dataset" )

@@ -266,79 +238,25 @@ - - - - - - - - - - - - - - - - - - - - -
$i18n.getString( "available_data_elements" )$i18n.getString( "filter" )$i18n.getString( "selected_data_elements" )
- - -
-
-
- -
- -
- -
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
$i18n.getString( "available_indicators" )$i18n.getString( "filter" )$i18n.getString( "selected_indicators" )
- - -
-
-
- -
- -
- - -
+#jqSelected({ + "prefix": "de", + "i18n_available": "available_data_elements", + "i18n_selected": "selected_data_elements" +}) + +#jqSelected({ + "prefix": "in", + "i18n_available": "available_indicators", + "i18n_selected": "selected_indicators" +}) + + + + + +
+ + +
+ === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm 2014-01-23 11:54:46 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/webapp/dhis-web-maintenance-dataset/editDataSet.vm 2014-04-07 07:19:13 +0000 @@ -1,66 +1,38 @@

$i18n.getString( "edit_dataset" )

@@ -158,7 +130,7 @@ - + @@ -237,7 +209,7 @@ - + @@ -269,87 +241,26 @@ - - - - - - - - - - - - - - - - - - - - - - - - -
$i18n.getString( "available_data_elements" )$i18n.getString( "filter" )$i18n.getString( "selected_data_elements" )
- - -
-
-
- -
- -
- -
- - - - - - - - - - - - - - - - - - - - - - - - - - -
$i18n.getString( "available_indicators" )$i18n.getString( "filter" )$i18n.getString( "selected_indicators" )
- - -
-
-
- -
- -
- - -
+#jqSelected({ + "prefix": "de", + "i18n_available": "available_data_elements", + "i18n_selected": "selected_data_elements", + "objects": $dataElements +}) + +#jqSelected({ + "prefix": "in", + "i18n_available": "available_indicators", + "i18n_selected": "selected_indicators", + "objects": $indicators +}) + + + + + +
+ + +
=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateUserForm.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateUserForm.vm 2014-04-07 02:08:51 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateUserForm.vm 2014-04-07 07:19:13 +0000 @@ -183,44 +183,3 @@

- - - -