=== modified file 'dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/controllers.js' --- dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/controllers.js 2015-01-13 17:31:37 +0000 +++ dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/controllers.js 2015-01-13 22:47:45 +0000 @@ -366,7 +366,7 @@ $scope.editingEventInGrid = false; $scope.currentElement.updated = false; - $scope.outerForm.$valid = true; + //$scope.outerForm.$valid = true; $scope.currentEvent = {}; }; @@ -593,14 +593,8 @@ DHIS2EventFactory.update(updatedEvent).then(function(data){ - //update original value - var continueLoop = true; - for(var i=0; i< $scope.dhis2Events.length && continueLoop; i++){ - if($scope.dhis2Events[i].event === $scope.currentEvent.event ){ - $scope.dhis2Events[i] = $scope.currentEvent; - continueLoop = false; - } - } + //reflect the change in the gird + $scope.resetEventValue($scope.currentEvent); $scope.currentEventOrginialValue = angular.copy($scope.currentEvent); $scope.outerForm.submitted = false; @@ -617,20 +611,23 @@ $scope.currentElement = {id: dataElement}; //get new and old values - var newValue = currentEvent[dataElement]; + var newValue = $scope.currentEvent[dataElement]; var oldValue = $scope.currentEventOrginialValue[dataElement]; //check for form validity - $scope.outerForm.submitted = true; - if( $scope.outerForm.$invalid ){ - $scope.currentElement.updated = false; - currentEvent[dataElement] = oldValue; - return; - } + if( $scope.isFormInvalid() ){ + $scope.currentElement.updated = false; + //reset value back to original + $scope.currentEvent[dataElement] = oldValue; + $scope.resetEventValue($scope.currentEvent); + return; + } - if( $scope.prStDes[dataElement].compulsory && !newValue ) { - currentEvent[dataElement] = oldValue; - $scope.currentElement.updated = false; + if( $scope.prStDes[dataElement].compulsory && !newValue ) { + $scope.currentElement.updated = false; + //reset value back to original + $scope.currentEvent[dataElement] = oldValue; + $scope.resetEventValue($scope.currentEvent); return; } @@ -645,21 +642,16 @@ newValue = DateUtils.formatFromUserToApi(newValue); } - var updatedSingleValueEvent = {event: currentEvent.event, dataValues: [{value: newValue, dataElement: dataElement}]}; - var updatedFullValueEvent = DHIS2EventService.reconstructEvent(currentEvent, $scope.selectedProgramStage.programStageDataElements); + var updatedSingleValueEvent = {event: $scope.currentEvent.event, dataValues: [{value: newValue, dataElement: dataElement}]}; + var updatedFullValueEvent = DHIS2EventService.reconstructEvent($scope.currentEvent, $scope.selectedProgramStage.programStageDataElements); DHIS2EventFactory.updateForSingleValue(updatedSingleValueEvent, updatedFullValueEvent).then(function(data){ - var continueLoop = true; - for(var i=0; i< $scope.dhis2Events.length && continueLoop; i++){ - if($scope.dhis2Events[i].event === currentEvent.event ){ - $scope.dhis2Events[i] = currentEvent; - continueLoop = false; - } - } + //reflect the new value in the grid + $scope.resetEventValue($scope.currentEvent); //update original value - $scope.currentEventOrginialValue = angular.copy(currentEvent); + $scope.currentEventOrginialValue = angular.copy($scope.currentEvent); $scope.currentElement.updated = true; $scope.updateSuccess = true; @@ -667,6 +659,16 @@ } }; + $scope.resetEventValue = function(currentEvent){ + var continueLoop = true; + for(var i=0; i< $scope.dhis2Events.length && continueLoop; i++){ + if($scope.dhis2Events[i].event === currentEvent.event ){ + $scope.dhis2Events[i] = currentEvent; + continueLoop = false; + } + } + }; + $scope.removeEvent = function(){ var dhis2Event = ContextMenuSelectedItem.getSelectedItem(); === modified file 'dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js' --- dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js 2015-01-13 17:31:37 +0000 +++ dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/scripts/services.js 2015-01-13 22:47:45 +0000 @@ -313,21 +313,4 @@ return e; } }; -}) - -/* Error messages*/ -.service('ErrorMessageService', function(){ - this.errorMessages = {}; - - this.setErrorMessages = function(errorMessages){ - this.errorMessages = errorMessages; - }; - - this.getErrorMessages = function(){ - return this.errorMessages; - }; - - this.get = function(id){ - return this.errorMessages[id]; - }; }); \ No newline at end of file === modified file 'dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/views/eventList.html' --- dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/views/eventList.html 2014-12-09 23:24:16 +0000 +++ dhis-2/dhis-web/dhis-web-apps/src/main/webapp/dhis-web-event-capture/views/eventList.html 2015-01-13 22:47:45 +0000 @@ -114,8 +114,7 @@ -