=== added file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/appmanager/AppStatus.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/appmanager/AppStatus.java 1970-01-01 00:00:00 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/appmanager/AppStatus.java 2015-10-09 21:43:56 +0000 @@ -0,0 +1,34 @@ +package org.hisp.dhis.appmanager; + +/* + * Copyright (c) 2004-2015, University of Oslo + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * Neither the name of the HISP project nor the names of its contributors may + * be used to endorse or promote products derived from this software without + * specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +public enum AppStatus +{ + OK, NAMESPACE_TAKEN; +} === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/appmanager/DefaultAppManager.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/appmanager/DefaultAppManager.java 2015-10-09 21:21:12 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/appmanager/DefaultAppManager.java 2015-10-09 21:43:56 +0000 @@ -1,5 +1,31 @@ package org.hisp.dhis.appmanager; +import java.io.File; +import java.io.IOException; +import java.io.InputStream; +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.stream.Collectors; +import java.util.zip.ZipEntry; +import java.util.zip.ZipFile; + +import javax.annotation.PostConstruct; + +import org.apache.ant.compress.taskdefs.Unzip; +import org.apache.commons.io.FileUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; +import org.hisp.dhis.datavalue.DefaultDataValueService; +import org.hisp.dhis.keyjsonvalue.KeyJsonValueService; +import org.hisp.dhis.setting.Setting; +import org.hisp.dhis.setting.SystemSettingManager; +import org.hisp.dhis.user.CurrentUserService; +import org.hisp.dhis.user.User; +import org.hisp.dhis.user.UserCredentials; +import org.springframework.beans.factory.annotation.Autowired; + /* * Copyright (c) 2004-2015, University of Oslo * All rights reserved. @@ -31,33 +57,6 @@ import com.fasterxml.jackson.databind.DeserializationFeature; import com.fasterxml.jackson.databind.ObjectMapper; -import org.apache.ant.compress.taskdefs.Unzip; -import org.apache.commons.io.FileUtils; -import org.apache.commons.lang3.StringUtils; -import org.apache.commons.logging.Log; -import org.apache.commons.logging.LogFactory; -import org.hisp.dhis.datavalue.DefaultDataValueService; -import org.hisp.dhis.keyjsonvalue.KeyJsonValueService; -import org.hisp.dhis.setting.Setting; -import org.hisp.dhis.setting.SystemSettingManager; -import org.hisp.dhis.user.CurrentUserService; -import org.hisp.dhis.user.User; -import org.hisp.dhis.user.UserCredentials; -import org.springframework.beans.factory.annotation.Autowired; - -import javax.annotation.PostConstruct; - -import java.io.File; -import java.io.IOException; -import java.io.InputStream; -import java.util.ArrayList; -import java.util.HashMap; -import java.util.List; -import java.util.function.BiConsumer; -import java.util.stream.Collectors; -import java.util.zip.ZipEntry; -import java.util.zip.ZipFile; - /** * @author Saptarshi Purkayastha */ @@ -146,24 +145,24 @@ // --------------------------------------------------------------------- // Check for namespace and if it's already taken by another app // --------------------------------------------------------------------- + String appNamespace = app.getActivities().getDhis().getNamespace(); - if ( appNamespace != null && - ( this.appNamespaces.containsKey( appNamespace ) && !app.equals( appNamespaces.get( appNamespace ) ) ) ) + if ( appNamespace != null && ( this.appNamespaces.containsKey( appNamespace ) && + !app.equals( appNamespaces.get( appNamespace ) ) ) ) { return AppStatus.NAMESPACE_TAKEN; } - // --------------------------------------------------------------------- // Delete if app is already installed // --------------------------------------------------------------------- + if ( getApps().contains( app ) ) { String folderPath = getAppFolderPath() + File.separator + app.getFolderName(); FileUtils.forceDelete( new File( folderPath ) ); } - String dest = getAppFolderPath() + File.separator + fileName.substring( 0, fileName.lastIndexOf( '.' ) ); Unzip unzip = new Unzip(); unzip.setSrc( file );