=== modified file 'local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerService.java' --- local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerService.java 2014-11-14 10:23:57 +0000 +++ local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerService.java 2014-11-15 09:02:15 +0000 @@ -29,6 +29,6 @@ Collection getPartner( OrganisationUnit organisationUnit, DataElement dataElement ); - Map getOrgUnitCountFromPartner( Integer organisationUnitId, Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ); + Map getOrgUnitCountFromPartner( Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ); } === modified file 'local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerStore.java' --- local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerStore.java 2014-11-14 10:23:57 +0000 +++ local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/api/PartnerStore.java 2014-11-15 09:02:15 +0000 @@ -29,6 +29,6 @@ Collection getPartner( OrganisationUnit organisationUnit, DataElement dataElement ); - Map getOrgUnitCountFromPartner( Integer organisationUnitId, Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ); + Map getOrgUnitCountFromPartner( Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ); } === modified file 'local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/DefaultPartnerService.java' --- local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/DefaultPartnerService.java 2014-11-14 10:23:57 +0000 +++ local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/DefaultPartnerService.java 2014-11-15 09:02:15 +0000 @@ -10,10 +10,12 @@ import org.hisp.dhis.rbf.api.Partner; import org.hisp.dhis.rbf.api.PartnerService; import org.hisp.dhis.rbf.api.PartnerStore; +import org.springframework.transaction.annotation.Transactional; /** * @author Mithilesh Kumar Thakur */ +@Transactional public class DefaultPartnerService implements PartnerService { // ------------------------------------------------------------------------- @@ -74,9 +76,9 @@ return partnerStore.getPartner( organisationUnit, dataElement ); } - public Map getOrgUnitCountFromPartner( Integer organisationUnitId, Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ) + public Map getOrgUnitCountFromPartner( Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ) { - return partnerStore.getOrgUnitCountFromPartner( organisationUnitId, dataSetId, dataElementId, optionId, startDate, endDate ); + return partnerStore.getOrgUnitCountFromPartner( dataSetId, dataElementId, optionId, startDate, endDate ); } } === modified file 'local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/HibernatePartnerStore.java' --- local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/HibernatePartnerStore.java 2014-11-14 10:23:57 +0000 +++ local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/impl/HibernatePartnerStore.java 2014-11-15 09:02:15 +0000 @@ -18,10 +18,12 @@ import org.hisp.dhis.rbf.api.PartnerStore; import org.springframework.jdbc.core.JdbcTemplate; import org.springframework.jdbc.support.rowset.SqlRowSet; +import org.springframework.transaction.annotation.Transactional; /** * @author Mithilesh Kumar Thakur */ +@Transactional public class HibernatePartnerStore implements PartnerStore { @@ -125,7 +127,7 @@ } // get OrgUnit Count FromPartner - public Map getOrgUnitCountFromPartner( Integer organisationUnitId, Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ) + public Map getOrgUnitCountFromPartner( Integer dataSetId, Integer dataElementId, Integer optionId, String startDate, String endDate ) { Map partnerOrgUnitCountMap = new HashMap(); @@ -134,13 +136,12 @@ try { - String query = "SELECT datasetid, dataelementid, optionid, startdate, enddate ,COUNT( organisationunitid) FROM partner " + + String query = "SELECT datasetid, dataelementid, optionid, startdate, enddate ,COUNT( organisationunitid ) FROM partner " + " WHERE " + - " organisationunitid = " + organisationUnitId + " AND " + " datasetid = " + dataSetId + " AND " + " dataelementid = " + dataElementId + " AND " + " optionid = " + optionId + " AND " + - " startdate = '" + startDate + "' AND enddate >= '" + endDate +"' GROUP BY datasetid, dataelementid, startdate, enddate, optionid "; + " startdate >= '" + startDate + "' AND enddate <= '" + endDate +"' GROUP BY datasetid, dataelementid, startdate, enddate, optionid "; SqlRowSet rs = jdbcTemplate.queryForRowSet( query ); === modified file 'local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/partner/action/PartnerFormAction.java' --- local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/partner/action/PartnerFormAction.java 2014-11-15 05:37:54 +0000 +++ local/in/dhis-web-maintenance-rbf/src/main/java/org/hisp/dhis/rbf/partner/action/PartnerFormAction.java 2014-11-15 09:02:15 +0000 @@ -1,15 +1,11 @@ package org.hisp.dhis.rbf.partner.action; -import java.util.ArrayList; -import java.util.List; - +import org.hisp.dhis.dataelement.DataElement; +import org.hisp.dhis.dataelement.DataElementService; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.option.Option; import org.hisp.dhis.option.OptionService; -import org.hisp.dhis.option.OptionSet; -import org.hisp.dhis.rbf.api.Lookup; -import org.hisp.dhis.rbf.api.LookupService; import org.springframework.beans.factory.annotation.Autowired; import com.opensymphony.xwork2.Action; @@ -32,7 +28,7 @@ private DataSetService dataSetService; @Autowired - private LookupService lookupService; + private DataElementService dataElementService; // ------------------------------------------------------------------------- // Input & Output @@ -59,19 +55,27 @@ this.dataElementId = dataElementId; } - private List dataSets = new ArrayList(); - - public List getDataSets() - { - return dataSets; - } - - private List