=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/security/oauth2/DefaultClientDetailsService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/security/oauth2/DefaultClientDetailsService.java 2015-06-21 04:35:23 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/security/oauth2/DefaultClientDetailsService.java 2015-06-21 10:51:09 +0000 @@ -28,6 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.google.common.collect.Sets; import org.hisp.dhis.oauth2.OAuth2Client; import org.hisp.dhis.oauth2.OAuth2ClientService; import org.springframework.beans.factory.annotation.Autowired; @@ -36,7 +37,6 @@ import org.springframework.security.oauth2.provider.ClientRegistrationException; import org.springframework.security.oauth2.provider.client.BaseClientDetails; -import java.util.HashSet; import java.util.Set; /** @@ -47,6 +47,11 @@ @Autowired private OAuth2ClientService oAuth2ClientService; + private final Set GRANT_TYPES = + Sets.newHashSet( "password", "authorization_code", "refresh_token" ); + + private final Set SCOPES = Sets.newHashSet( "ALL" ); + @Override public ClientDetails loadClientByClientId( String clientId ) throws ClientRegistrationException { @@ -67,21 +72,11 @@ return null; } - Set grantTypes = new HashSet<>(); - grantTypes.add( "password" ); - grantTypes.add( "authorization_code" ); - grantTypes.add( "refresh_token" ); - grantTypes.add( "client_credentials" ); - grantTypes.add( "implicit" ); - - Set scopes = new HashSet<>(); - scopes.add( "ALL" ); - BaseClientDetails clientDetails = new BaseClientDetails(); clientDetails.setClientId( client.getCid() ); clientDetails.setClientSecret( client.getSecret() ); - clientDetails.setAuthorizedGrantTypes( grantTypes ); - clientDetails.setScope( scopes ); + clientDetails.setAuthorizedGrantTypes( GRANT_TYPES ); + clientDetails.setScope( SCOPES ); return clientDetails; } === modified file 'dhis-2/dhis-web/dhis-web-commons/src/main/resources/META-INF/dhis/security.xml' --- dhis-2/dhis-web/dhis-web-commons/src/main/resources/META-INF/dhis/security.xml 2015-06-21 09:33:34 +0000 +++ dhis-2/dhis-web/dhis-web-commons/src/main/resources/META-INF/dhis/security.xml 2015-06-21 10:51:09 +0000 @@ -115,7 +115,7 @@ - + === modified file 'dhis-2/pom.xml' --- dhis-2/pom.xml 2015-06-18 08:03:48 +0000 +++ dhis-2/pom.xml 2015-06-21 10:51:09 +0000 @@ -1032,7 +1032,7 @@ UTF-8 4.1.6.RELEASE 3.2.7.RELEASE - 2.0.7.RELEASE + 2.0.5.RELEASE 2.3.16.3 4.2.19.Final 4.3.1.Final