=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java 2015-06-16 10:36:25 +0000 @@ -98,7 +98,7 @@ void deleteChart( Chart chart ); - Collection getAllCharts(); + List getAllCharts(); Chart getChartByName( String name ); === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java 2015-03-27 17:33:25 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java 2015-06-16 10:36:25 +0000 @@ -93,7 +93,7 @@ List getBetweenLikeName( Class clazz, Set words, int first, int max ); - Collection getByLastUpdated( Class clazz, Date lastUpdated ); + List getByLastUpdated( Class clazz, Date lastUpdated ); Collection getByCreated( Class clazz, Date created ); === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessService.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessService.java 2015-06-16 10:36:25 +0000 @@ -29,6 +29,7 @@ */ import java.util.Collection; +import java.util.List; import java.util.Set; import java.util.concurrent.Future; @@ -58,12 +59,12 @@ * * @param periodId the identifier of the Period. * @param organisationUnitId the identifier of the root OrganisationUnit. - * @return a Collection of DataSetCompletenessResults. + * @return a List of DataSetCompletenessResults. */ - Collection getDataSetCompleteness( int periodId, int organisationUnitId, Set groupIds ); + List getDataSetCompleteness( int periodId, int organisationUnitId, Set groupIds ); /** - * Returns a Collection of DataSetCompletenessResults. The + * Returns a List of DataSetCompletenessResults. The * DataSetCompletenessResult object contains the name of the associated * OrganisationUnit, the number of sources being associated with the DataSet * AND being a child of the OrganisationUnit, and the number of @@ -75,9 +76,9 @@ * @param parentOrganisationUnitId the identifier of the parent * OrganisationUnit. * @param dataSetId the identifier of the DataSet. - * @return a Collection of DataSetCompletenessResults. + * @return a List of DataSetCompletenessResults. */ - Collection getDataSetCompleteness( int periodId, + List getDataSetCompleteness( int periodId, Collection organisationUnitIds, int dataSetId, Set groupIds ); /** === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/completeness/DataSetCompletenessStore.java 2015-06-16 10:36:25 +0000 @@ -31,6 +31,7 @@ import org.hisp.dhis.dataset.DataSet; import java.util.Collection; +import java.util.List; /** * @author Lars Helge Overland @@ -48,7 +49,7 @@ Integer getCompulsoryDataElementRegistrations( DataSet dataSet, Collection children, Collection periods, int completenessOffset ); - Collection getDataSetsWithRegistrations( Collection dataSets ); + List getDataSetsWithRegistrations( Collection dataSets ); /** * Gets the percentage value for the datasetcompleteness with the given parameters. === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/report/ReportService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/report/ReportService.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/report/ReportService.java 2015-06-16 10:36:25 +0000 @@ -136,7 +136,7 @@ * * @param first the start index. * @param max the maximum number of reports. - * @return a collection of reports. + * @return a list of reports. */ List getReportsBetween( int first, int max ); @@ -146,7 +146,7 @@ * * @param first the start index. * @param max the maximum number of reports. - * @return a collection of reports. + * @return a List of reports. */ List getReportsBetweenByName( String name, int first, int max ); @@ -160,7 +160,7 @@ /** * Retrieves all Reports. * - * @return a Collection of Reports. + * @return a List of Reports. */ List getAllReports(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java 2015-05-28 17:30:20 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java 2015-06-16 10:36:25 +0000 @@ -556,7 +556,7 @@ @Override @SuppressWarnings( "unchecked" ) - public Collection getByLastUpdated( Class clazz, Date lastUpdated ) + public List getByLastUpdated( Class clazz, Date lastUpdated ) { GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); @@ -565,7 +565,7 @@ return new ArrayList<>(); } - return (Collection) store.getAllGeLastUpdated( lastUpdated ); + return (List) store.getAllGeLastUpdated( lastUpdated ); } @Override === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/chart/impl/DefaultChartService.java' --- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/chart/impl/DefaultChartService.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/chart/impl/DefaultChartService.java 2015-06-16 10:36:25 +0000 @@ -957,7 +957,7 @@ } @Override - public Collection getAllCharts() + public List getAllCharts() { return chartStore.getAll(); } @@ -971,7 +971,7 @@ @Override public Collection getCharts( final Collection identifiers ) { - Collection charts = getAllCharts(); + List charts = getAllCharts(); return identifiers == null ? charts : FilterUtils.filter( charts, new Filter() { === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java' --- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java 2015-06-16 10:36:25 +0000 @@ -28,8 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import static org.hisp.dhis.commons.util.ConversionUtils.getIdentifiers; - import java.util.ArrayList; import java.util.Collection; import java.util.HashSet; @@ -41,6 +39,7 @@ import org.amplecode.quick.BatchHandlerFactory; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; +import org.hisp.dhis.commons.util.ConversionUtils; import org.hisp.dhis.completeness.DataSetCompletenessResult; import org.hisp.dhis.completeness.DataSetCompletenessService; import org.hisp.dhis.completeness.DataSetCompletenessStore; @@ -55,7 +54,6 @@ import org.hisp.dhis.organisationunit.OrganisationUnitService; import org.hisp.dhis.period.Period; import org.hisp.dhis.period.PeriodService; -import org.hisp.dhis.commons.util.ConversionUtils; import org.springframework.scheduling.annotation.Async; import org.springframework.transaction.annotation.Transactional; @@ -190,20 +188,20 @@ @Override @Transactional - public Collection getDataSetCompleteness( int periodId, int organisationUnitId, Set groupIds ) + public List getDataSetCompleteness( int periodId, int organisationUnitId, Set groupIds ) { final Period period = periodService.getPeriod( periodId ); final Set children = organisationUnitService.getOrganisationUnitHierarchy().getChildren( organisationUnitId ); - final Collection dataSets = dataSetService.getAllDataSets(); + final List dataSets = dataSetService.getAllDataSets(); final List results = new ArrayList<>(); for ( final DataSet dataSet : dataSets ) { - final List periodsBetweenDates = getIdentifiers( Period.class, + final List periodsBetweenDates = ConversionUtils.getIdentifiers( Period.class, periodService.getPeriodsBetweenDates( dataSet.getPeriodType(), period.getStartDate(), period.getEndDate() ) ); final Set relevantSources = getRelevantSources( dataSet, children, groupIds ); @@ -231,14 +229,14 @@ @Override @Transactional - public Collection getDataSetCompleteness( int periodId, + public List getDataSetCompleteness( int periodId, Collection organisationUnitIds, int dataSetId, Set groupIds ) { final DataSet dataSet = dataSetService.getDataSet( dataSetId ); final Period period = periodService.getPeriod( periodId ); - final List periodsBetweenDates = getIdentifiers( Period.class, periodService.getPeriodsBetweenDates( dataSet.getPeriodType(), period.getStartDate(), period.getEndDate() ) ); + final List periodsBetweenDates = ConversionUtils.getIdentifiers( Period.class, periodService.getPeriodsBetweenDates( dataSet.getPeriodType(), period.getStartDate(), period.getEndDate() ) ); final List results = new ArrayList<>(); === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java' --- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/jdbc/JDBCDataSetCompletenessStore.java 2015-06-16 10:36:25 +0000 @@ -32,6 +32,7 @@ import java.util.ArrayList; import java.util.Collection; +import java.util.List; import org.amplecode.quick.StatementManager; import org.apache.commons.logging.Log; @@ -158,9 +159,9 @@ // ------------------------------------------------------------------------- @Override - public Collection getDataSetsWithRegistrations( Collection dataSets ) + public List getDataSetsWithRegistrations( Collection dataSets ) { - Collection selection = new ArrayList<>(); + List selection = new ArrayList<>(); for ( DataSet dataSet : dataSets ) { === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceExportTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceExportTest.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceExportTest.java 2015-06-16 10:36:25 +0000 @@ -41,7 +41,7 @@ import org.springframework.beans.factory.annotation.Autowired; import java.util.ArrayList; -import java.util.Collection; +import java.util.List; import static org.hisp.dhis.commons.util.ConversionUtils.getIdentifiers; import static org.junit.Assert.assertEquals; @@ -92,11 +92,11 @@ private DataSet dataSetA; - private Collection dataSets; - - private Collection periods; - - private Collection units; + private List dataSets; + + private List periods; + + private List units; @Override public void setUpTest() === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceTest.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/completeness/DataSetCompletenessServiceTest.java 2015-06-16 10:36:25 +0000 @@ -48,6 +48,7 @@ import java.util.Collection; import java.util.Date; import java.util.HashSet; +import java.util.List; import java.util.Set; import javax.annotation.Resource; @@ -288,7 +289,7 @@ registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetC, periodA, unitC, null, tooLateA, "") ); registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetC, periodB, unitA, null, tooLateB, "") ); - Collection results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); + List results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); assertNotNull( results ); assertEquals( 3, results.size() ); @@ -334,7 +335,7 @@ registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetC, periodA, unitA, null, tooLateA, "") ); registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetC, periodA, unitB, null, onTimeA, "") ); - Collection results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); + List results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); assertNotNull( results ); assertEquals( 3, results.size() ); @@ -373,7 +374,7 @@ registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetA, periodB, unitF, null, onTimeB, "") ); registrationService.saveCompleteDataSetRegistration( new CompleteDataSetRegistration( dataSetA, periodB, unitG, null, tooLateB, "") ); - Collection results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); + List results = registrationCompletenessService.getDataSetCompleteness( periodIdA, unitIdA, null ); assertNotNull( results ); assertEquals( 1, results.size() ); @@ -415,7 +416,7 @@ groupIds.clear(); groupIds.add( groupA.getId() ); - Collection results = registrationCompletenessService.getDataSetCompleteness( periodIdC, unitIdA, groupIds ); + List results = registrationCompletenessService.getDataSetCompleteness( periodIdC, unitIdA, groupIds ); assertNotNull( results ); assertEquals( 3, results.size() ); === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentServiceTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentServiceTest.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentServiceTest.java 2015-06-16 10:36:25 +0000 @@ -28,14 +28,17 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertNotNull; +import static org.junit.Assert.assertNull; +import static org.junit.Assert.assertTrue; + +import java.util.List; + import org.hisp.dhis.DhisSpringTest; import org.junit.Test; import org.springframework.beans.factory.annotation.Autowired; -import java.util.Collection; - -import static org.junit.Assert.*; - /** * @author Lars Helge Overland * @version $Id$ @@ -93,7 +96,7 @@ documentService.saveDocument( documentB ); documentService.saveDocument( documentC ); - Collection actual = documentService.getAllDocuments(); + List actual = documentService.getAllDocuments(); assertEquals( 3, actual.size() ); assertTrue( actual.contains( documentA ) ); === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentStoreTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentStoreTest.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/document/DocumentStoreTest.java 2015-06-16 10:36:25 +0000 @@ -33,7 +33,7 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -import java.util.Collection; +import java.util.List; import javax.annotation.Resource; @@ -98,7 +98,7 @@ documentStore.save( documentB ); documentStore.save( documentC ); - Collection actual = documentStore.getAll(); + List actual = documentStore.getAll(); assertEquals( 3, actual.size() ); assertTrue( actual.contains( documentA ) ); === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/report/ReportStoreTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/report/ReportStoreTest.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/report/ReportStoreTest.java 2015-06-16 10:36:25 +0000 @@ -34,7 +34,7 @@ import static org.junit.Assert.assertNull; import static org.junit.Assert.assertTrue; -import java.util.Collection; +import java.util.List; import javax.annotation.Resource; @@ -146,7 +146,7 @@ reportStore.save( reportA ); reportStore.save( reportB ); - Collection reports = reportStore.getAll(); + List reports = reportStore.getAll(); assertNotNull( reports ); assertEquals( 2, reports.size() ); === modified file 'dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/reporttable/ReportTableStoreTest.java' --- dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/reporttable/ReportTableStoreTest.java 2015-03-31 15:22:00 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/test/java/org/hisp/dhis/reporttable/ReportTableStoreTest.java 2015-06-16 10:36:25 +0000 @@ -34,7 +34,6 @@ import static org.junit.Assert.assertTrue; import java.util.ArrayList; -import java.util.Collection; import java.util.List; import javax.annotation.Resource; @@ -275,7 +274,7 @@ reportTableStore.save( reportTableA ); reportTableStore.save( reportTableB ); - Collection reportTables = reportTableStore.getAll(); + List reportTables = reportTableStore.getAll(); assertTrue( reportTables.contains( reportTableA ) ); assertTrue( reportTables.contains( reportTableB ) ); === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/AggregatedValueController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/AggregatedValueController.java 2015-03-31 15:22:00 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/AggregatedValueController.java 2015-06-16 10:36:25 +0000 @@ -28,30 +28,30 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import java.io.IOException; +import java.util.ArrayList; +import java.util.List; + +import javax.servlet.http.HttpServletResponse; + import org.hisp.dhis.aggregation.AggregatedDataValue; import org.hisp.dhis.aggregation.AggregatedDataValueService; import org.hisp.dhis.aggregation.AggregatedIndicatorValue; -import org.hisp.dhis.webapi.utils.ContextUtils; +import org.hisp.dhis.dataelement.DataElementService; import org.hisp.dhis.dxf2.common.JacksonUtils; -import org.hisp.dhis.dataelement.DataElementService; import org.hisp.dhis.i18n.I18nManager; import org.hisp.dhis.indicator.IndicatorService; import org.hisp.dhis.organisationunit.OrganisationUnitService; import org.hisp.dhis.period.Period; import org.hisp.dhis.period.PeriodService; import org.hisp.dhis.period.RelativePeriods; +import org.hisp.dhis.webapi.utils.ContextUtils; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.stereotype.Controller; import org.springframework.web.bind.annotation.RequestMapping; import org.springframework.web.bind.annotation.RequestMethod; import org.springframework.web.bind.annotation.RequestParam; -import javax.servlet.http.HttpServletResponse; -import java.io.IOException; -import java.util.ArrayList; -import java.util.Collection; -import java.util.List; - /** * @author Morten Olav Hansen */ @@ -111,9 +111,9 @@ rp.setLastYear( lastYear ); rp.setLast5Years( lastFiveYears ); - Collection periods = periodService.reloadPeriods( rp.getRelativePeriods() ); + List periods = periodService.reloadPeriods( rp.getRelativePeriods() ); - Collection periodIds = new ArrayList<>(); + List periodIds = new ArrayList<>(); for ( Period period : periods ) { === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataSetController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataSetController.java 2015-02-17 06:00:52 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/DataSetController.java 2015-06-16 10:36:25 +0000 @@ -31,7 +31,6 @@ import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; -import java.util.Collection; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -241,7 +240,7 @@ { i18nService.internationalise( ou ); - Collection dataValues = dataValueService.getDataValues( ou, pe, dataSets.get( 0 ).getDataElements() ); + List dataValues = dataValueService.getDataValues( ou, pe, dataSets.get( 0 ).getDataElements() ); FormUtils.fillWithDataValues( form, dataValues ); } === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/mapping/GeoFeatureController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/mapping/GeoFeatureController.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/mapping/GeoFeatureController.java 2015-06-16 10:36:25 +0000 @@ -56,7 +56,6 @@ import javax.servlet.http.HttpServletResponse; import java.io.IOException; import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.Comparator; import java.util.HashMap; @@ -154,7 +153,7 @@ return null; } - Collection groupSets = includeGroupSets ? organisationUnitGroupService.getAllOrganisationUnitGroupSets() : null; + List groupSets = includeGroupSets ? organisationUnitGroupService.getAllOrganisationUnitGroupSets() : null; List features = new ArrayList<>(); === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/organisationunit/OrganisationUnitLocationController.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/organisationunit/OrganisationUnitLocationController.java 2015-06-15 13:44:20 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/controller/organisationunit/OrganisationUnitLocationController.java 2015-06-16 10:36:25 +0000 @@ -47,7 +47,6 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import java.util.ArrayList; -import java.util.Collection; import java.util.List; import java.util.Map; import java.util.Set; @@ -160,7 +159,7 @@ { boolean withinOrgUnit = false; - Collection organisationUnits = new ArrayList<>(); + List organisationUnits = new ArrayList<>(); organisationUnits.add( organisationUnitService.getOrganisationUnit( orgUnitUid ) ); FilterUtils.filter( organisationUnits, new OrganisationUnitPolygonCoveringCoordinateFilter( longitude, latitude ) ); === modified file 'dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetPeriodsAction.java' --- dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetPeriodsAction.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetPeriodsAction.java 2015-06-16 10:36:25 +0000 @@ -29,7 +29,6 @@ */ import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.List; @@ -94,7 +93,7 @@ { if ( name == null || name.equals( ALL ) ) { - Collection periodTypes = periodService.getAllPeriodTypes(); + List periodTypes = periodService.getAllPeriodTypes(); periods = new ArrayList<>(); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java 2015-02-19 09:18:17 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java 2015-06-16 10:36:25 +0000 @@ -90,15 +90,15 @@ { this.paging = createPaging( attributeService.getAttributeCountByName( key ) ); - attributes = new ArrayList<>( attributeService.getAttributesBetweenByName( key, - paging.getStartPos(), paging.getPageSize() ) ); + attributes = attributeService.getAttributesBetweenByName( key, + paging.getStartPos(), paging.getPageSize() ); } else { this.paging = createPaging( attributeService.getAttributeCount() ); - attributes = new ArrayList<>( attributeService.getAttributesBetween( paging.getStartPos(), - paging.getPageSize() ) ); + attributes = attributeService.getAttributesBetween( paging.getStartPos(), + paging.getPageSize() ); } Collections.sort( attributes, IdentifiableObjectNameComparator.INSTANCE ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java 2015-06-16 10:36:25 +0000 @@ -73,7 +73,7 @@ @Override public String execute() { - attributes = new ArrayList<>( attributeService.getAllAttributes() ); + attributes = attributeService.getAllAttributes(); Collections.sort( attributes, new AttributeSortOrderComparator() ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/constant/GetConstantListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/constant/GetConstantListAction.java 2015-02-19 09:18:17 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/constant/GetConstantListAction.java 2015-06-16 10:36:25 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List; @@ -95,13 +94,13 @@ { this.paging = createPaging( constantService.getConstantCountByName( key ) ); - constants = new ArrayList<>( constantService.getConstantsBetweenByName( key, paging.getStartPos(), paging.getPageSize() ) ); + constants = constantService.getConstantsBetweenByName( key, paging.getStartPos(), paging.getPageSize() ); } else { this.paging = createPaging( constantService.getConstantCount() ); - constants = new ArrayList<>( constantService.getConstantsBetween( paging.getStartPos(), paging.getPageSize() ) ); + constants = constantService.getConstantsBetween( paging.getStartPos(), paging.getPageSize() ); } Collections.sort( constants, IdentifiableObjectNameComparator.INSTANCE ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/databrowser/GetPeriodTypesAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/databrowser/GetPeriodTypesAction.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/databrowser/GetPeriodTypesAction.java 2015-06-16 10:36:25 +0000 @@ -28,7 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; +import java.util.List; import org.hisp.dhis.period.PeriodService; import org.hisp.dhis.period.PeriodType; @@ -57,9 +57,9 @@ // Output // ------------------------------------------------------------------------- - private Collection periodTypes; + private List periodTypes; - public Collection getPeriodTypes() + public List getPeriodTypes() { return periodTypes; } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/locale/GetLocaleListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/locale/GetLocaleListAction.java 2015-02-19 09:18:17 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/locale/GetLocaleListAction.java 2015-06-16 10:36:25 +0000 @@ -109,8 +109,8 @@ this.paging = createPaging( total ); - i18nlocales = new ArrayList<>( localeService.getI18nLocalesBetweenLikeName( key, paging.getStartPos(), - paging.getPageSize() ) ); + i18nlocales = localeService.getI18nLocalesBetweenLikeName( key, paging.getStartPos(), + paging.getPageSize() ); } else { @@ -118,8 +118,8 @@ this.paging = createPaging( total ); - i18nlocales = new ArrayList<>( localeService.getI18nLocalesBetween( paging.getStartPos(), - paging.getPageSize() ) ); + i18nlocales = localeService.getI18nLocalesBetween( paging.getStartPos(), + paging.getPageSize() ); } Collections.sort( i18nlocales, IdentifiableObjectNameComparator.INSTANCE ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionListAction.java 2015-01-17 07:41:26 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionListAction.java 2015-06-16 10:36:25 +0000 @@ -28,7 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; +import java.util.List; import org.hisp.dhis.option.Option; import org.hisp.dhis.option.OptionService; @@ -89,9 +89,9 @@ return optionSet; } - private Collection