=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/i18n_global.properties' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/i18n_global.properties 2015-10-15 14:07:18 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/i18n_global.properties 2015-10-19 19:21:51 +0000 @@ -706,7 +706,7 @@ closed_date=Closed date active=Active type=Type -value_type=Value Type +value_type=Value type actual=Actual target=Target percent=Percent === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/AddDataElementAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/AddDataElementAction.java 2015-10-15 10:22:39 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/AddDataElementAction.java 2015-10-19 19:21:51 +0000 @@ -123,9 +123,9 @@ this.domainType = domainType; } - private String valueType; + private ValueType valueType; - public void setValueType( String valueType ) + public void setValueType( ValueType valueType ) { this.valueType = valueType; } @@ -215,13 +215,15 @@ OptionSet commentOptionSet = optionService.getOptionSet( selectedCommentOptionSetId ); LegendSet legendSet = legendService.getLegendSet( selectedLegendSetId ); + valueType = optionSet != null && optionSet.getValueType() != null ? optionSet.getValueType() : valueType; + dataElement.setName( StringUtils.trimToNull( name ) ); dataElement.setShortName( StringUtils.trimToNull( shortName ) ); dataElement.setCode( StringUtils.trimToNull( code ) ); dataElement.setDescription( StringUtils.trimToNull( description ) ); dataElement.setFormName( StringUtils.trimToNull( formName ) ); dataElement.setDomainType( DataElementDomain.valueOf( domainType ) ); - dataElement.setValueType( ValueType.valueOf( valueType ) ); + dataElement.setValueType( valueType ); dataElement.setAggregationType( AggregationType.valueOf( aggregationType ) ); dataElement.setUrl( url ); dataElement.setZeroIsSignificant( zeroIsSignificant ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/UpdateDataElementAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/UpdateDataElementAction.java 2015-10-15 10:22:39 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/dataelement/UpdateDataElementAction.java 2015-10-19 19:21:51 +0000 @@ -136,9 +136,9 @@ this.domainType = domainType; } - private String valueType; + private ValueType valueType; - public void setValueType( String valueType ) + public void setValueType( ValueType valueType ) { this.valueType = valueType; } @@ -236,13 +236,15 @@ OptionSet commentOptionSet = optionService.getOptionSet( selectedCommentOptionSetId ); LegendSet legendSet = legendService.getLegendSet( selectedLegendSetId ); + valueType = optionSet != null && optionSet.getValueType() != null ? optionSet.getValueType() : valueType; + dataElement.setName( StringUtils.trimToNull( name ) ); dataElement.setShortName( StringUtils.trimToNull( shortName ) ); dataElement.setCode( StringUtils.trimToNull( code ) ); dataElement.setDescription( StringUtils.trimToNull( description ) ); dataElement.setFormName( StringUtils.trimToNull( formName ) ); dataElement.setDomainType( DataElementDomain.valueOf( domainType ) ); - dataElement.setValueType( ValueType.valueOf( valueType ) ); + dataElement.setValueType( valueType ); dataElement.setAggregationType( AggregationType.valueOf( aggregationType ) ); dataElement.setUrl( url ); dataElement.setZeroIsSignificant( zeroIsSignificant ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/resources/org/hisp/dhis/dd/i18n_module.properties' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/resources/org/hisp/dhis/dd/i18n_module.properties 2015-09-26 16:08:33 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/resources/org/hisp/dhis/dd/i18n_module.properties 2015-10-19 19:21:51 +0000 @@ -28,7 +28,7 @@ indicator_group=Indicator Group indicator_groups=Indicator Groups create_new_data_element=Create new data element -domain_type=Domain Type +domain_type=Domain type create_new_data_element_group=Create new data element group group_members=Group members available_data_elements=Available data elements === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/dataElementForm.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/dataElementForm.vm 2015-10-15 10:22:39 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/dataElementForm.vm 2015-10-19 19:21:51 +0000 @@ -19,17 +19,17 @@ 'rules': getValidationRules("dataElement") } ); - #if( $update ) + #if( $update ) checkValueIsExist("name", "validateDataElement.action", { id: getFieldValue('id') }); checkValueIsExist("shortName", "validateDataElement.action", { id: getFieldValue('id') }); checkValueIsExist("code", "validateDataElement.action", { id: getFieldValue('id') }); - updateAggreationOperation(getFieldValue('valueType')); - #else + dataValueOptionSetChanged(); + #else checkValueIsExist("name", "validateDataElement.action"); checkValueIsExist("shortName", "validateDataElement.action"); checkValueIsExist("code", "validateDataElement.action"); - #end + #end }); var previousName = '$!encoder.jsEscape( $!dataElement.name, "'" )'; @@ -85,6 +85,17 @@ + + + + + + - - - - - - === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/javascript/dataElement.js' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/javascript/dataElement.js 2015-10-15 10:22:39 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/webapp/dhis-web-maintenance-datadictionary/javascript/dataElement.js 2015-10-19 19:21:51 +0000 @@ -55,6 +55,18 @@ updateAggreationOperation(value); } +function dataValueOptionSetChanged() { + var optionSetId = $('#selectedOptionSetId').val(); + var valueType = $('#selectedOptionSetId').find(':selected').data('valuetype'); + if ( optionSetId != 0 && valueType ) { + $('#valueType').val(valueType); + $('#valueType').prop('disabled', true); + } + else { + $('#valueType').prop('disabled', false); + } +} + function updateAggreationOperation( value ) { if( isValueTypeText(value) || value == 'DATE' || value == 'TRUE_ONLY' ) { hideById("aggregationType"); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/AddAttributeAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/AddAttributeAction.java 2015-10-19 14:51:03 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/AddAttributeAction.java 2015-10-19 19:21:51 +0000 @@ -201,6 +201,8 @@ { OptionSet optionSet = optionService.getOptionSet( optionSetId ); + valueType = optionSet != null && optionSet.getValueType() != null ? optionSet.getValueType() : valueType; + TrackedEntityAttribute trackedEntityAttribute = new TrackedEntityAttribute(); trackedEntityAttribute.setName( StringUtils.trimToNull( name ) ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/UpdateAttributeAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/UpdateAttributeAction.java 2015-10-19 14:51:03 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/trackedentityattribute/UpdateAttributeAction.java 2015-10-19 19:21:51 +0000 @@ -206,6 +206,8 @@ throws Exception { OptionSet optionSet = optionService.getOptionSet( optionSetId ); + + valueType = optionSet != null && optionSet.getValueType() != null ? optionSet.getValueType() : valueType; TrackedEntityAttribute trackedEntityAttribute = trackedEntityAttributeService.getTrackedEntityAttribute( id ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/addAttributeForm.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/addAttributeForm.vm 2015-09-03 09:36:38 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/addAttributeForm.vm 2015-10-19 19:21:51 +0000 @@ -79,10 +79,21 @@ - + + + + + + + @@ -119,16 +130,6 @@ - - - - - - + + #foreach($optionSet in $optionSets) + + #end + + + + + - + - + - #foreach($optionSet in $optionSets) - - #end - - - -