=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/Program.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/Program.java 2014-08-14 08:16:44 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/Program.java 2014-08-14 08:39:46 +0000 @@ -79,13 +79,13 @@ private String dateOfIncidentDescription; @Scanned - private Set organisationUnits = new HashSet(); - - @Scanned - private List programStages = new ArrayList(); - - @Scanned - private Set validationCriteria = new HashSet(); + private Set organisationUnits = new HashSet<>(); + + @Scanned + private List programStages = new ArrayList<>(); + + @Scanned + private Set validationCriteria = new HashSet<>(); private Integer type; @@ -93,15 +93,15 @@ private Boolean ignoreOverdueEvents = false; - private List programAttributes = new ArrayList(); //TODO use List? + private List programAttributes = new ArrayList<>(); @Scanned - private Set userRoles = new HashSet(); + private Set userRoles = new HashSet<>(); private Boolean onlyEnrollOnce = false; @Scanned - private Set instanceReminders = new HashSet(); + private Set instanceReminders = new HashSet<>(); /** * Allow enrolling tracked entity to all org units disregarding whether the === modified file 'dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java' --- dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java 2014-07-27 13:15:50 +0000 +++ dhis-2/dhis-services/dhis-service-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java 2014-08-14 08:39:46 +0000 @@ -74,6 +74,7 @@ import java.lang.reflect.Field; import java.lang.reflect.Method; +import java.util.ArrayList; import java.util.Collection; import java.util.List; import java.util.Map; @@ -126,7 +127,7 @@ @Autowired private SchemaService schemaService; - @Autowired(required = false) + @Autowired( required = false ) private List> objectHandlers; //------------------------------------------------------------------------------------------------------- @@ -162,7 +163,7 @@ private Set greyedFields = Sets.newHashSet(); private Collection programStageDataElements = Lists.newArrayList(); - private Set programTrackedEntityAttributes = Sets.newHashSet(); + private List programTrackedEntityAttributes = new ArrayList<>(); public void extract( T object ) { @@ -253,7 +254,7 @@ private Expression extractExpression( T object, String fieldName ) { Expression expression = null; - + if ( ReflectionUtils.findGetterMethod( fieldName, object ) != null ) { expression = ReflectionUtils.invokeGetterMethod( fieldName, object ); @@ -364,7 +365,7 @@ } } - private void saveAttributeValues( T object, Set attributeValues ) + private void saveAttributeValues( T object, Collection attributeValues ) { if ( attributeValues.size() > 0 ) { @@ -411,18 +412,18 @@ } } - private Set extractProgramTrackedEntityAttributes( T object ) + private List extractProgramTrackedEntityAttributes( T object ) { - Set programTrackedEntityAttributeSet = Sets.newHashSet(); + List programTrackedEntityAttributeSet = new ArrayList<>(); - if ( ReflectionUtils.isCollection( "attributes", object, ProgramTrackedEntityAttribute.class ) ) + if ( ReflectionUtils.isCollection( "programAttributes", object, ProgramTrackedEntityAttribute.class ) ) { - Set programTrackedEntityAttributes = ReflectionUtils.invokeGetterMethod( "attributes", object ); + List programTrackedEntityAttributes = ReflectionUtils.invokeGetterMethod( "programAttributes", object ); if ( programTrackedEntityAttributes == null ) { - programTrackedEntityAttributes = Sets.newHashSet(); - ReflectionUtils.invokeSetterMethod( "attributes", object, programTrackedEntityAttributes ); + programTrackedEntityAttributes = new ArrayList<>(); + ReflectionUtils.invokeSetterMethod( "programAttributes", object, programTrackedEntityAttributes ); } for ( ProgramTrackedEntityAttribute trackedEntityAttribute : programTrackedEntityAttributes ) @@ -448,7 +449,7 @@ extractProgramTrackedEntityAttributes( object ); } - private void saveProgramTrackedEntityAttributes( T object, Set programTrackedEntityAttributes ) + private void saveProgramTrackedEntityAttributes( T object, Collection programTrackedEntityAttributes ) { for ( ProgramTrackedEntityAttribute programTrackedEntityAttribute : programTrackedEntityAttributes ) { @@ -457,7 +458,7 @@ sessionFactory.getCurrentSession().persist( programTrackedEntityAttribute ); } - ReflectionUtils.invokeSetterMethod( "programTrackedEntityAttributes", object, programTrackedEntityAttributes ); + ReflectionUtils.invokeSetterMethod( "programAttributes", object, programTrackedEntityAttributes ); } private Collection extractProgramStageDataElements( T object )