=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/AddRoleAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/AddRoleAction.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/AddRoleAction.java 2014-10-10 08:19:06 +0000 @@ -28,15 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.ArrayList; -import java.util.Collection; - +import com.opensymphony.xwork2.Action; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.user.UserAuthorityGroup; import org.hisp.dhis.user.UserService; -import com.opensymphony.xwork2.Action; +import java.util.ArrayList; +import java.util.Collection; /** * @author Thanh Nguyen @@ -109,8 +108,7 @@ for ( String id : selectedList ) { - DataSet dataSet = dataSetService.getDataSet( Integer.parseInt( id ) ); - + DataSet dataSet = dataSetService.getDataSet( id ); group.getDataSets().add( dataSet ); } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/UpdateRoleAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/UpdateRoleAction.java 2014-10-09 20:46:49 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/java/org/hisp/dhis/user/action/UpdateRoleAction.java 2014-10-10 08:19:06 +0000 @@ -28,15 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.ArrayList; -import java.util.Collection; - +import com.opensymphony.xwork2.Action; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.user.UserAuthorityGroup; import org.hisp.dhis.user.UserService; -import com.opensymphony.xwork2.Action; +import java.util.ArrayList; +import java.util.Collection; /** * @author Thanh Nguyen @@ -127,13 +126,6 @@ for ( String id : selectedList ) { DataSet dataSet = dataSetService.getDataSet( id ); - - if ( dataSet == null ) - { - //TODO fix this better. Currently some are UID, some ID. Should all be the same. - dataSet = dataSetService.getDataSet( Integer.parseInt( id ) ); - } - group.getDataSets().add( dataSet ); } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateRoleForm.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateRoleForm.vm 2013-07-19 08:23:53 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/src/main/webapp/dhis-web-maintenance-user/updateRoleForm.vm 2014-10-10 08:19:06 +0000 @@ -81,7 +81,7 @@