=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/attribute/AttributeService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/attribute/AttributeService.java 2015-06-16 05:11:29 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/attribute/AttributeService.java 2015-06-16 10:59:33 +0000 @@ -29,7 +29,6 @@ */ import java.util.List; -import java.util.Set; /** * @author Morten Olav Hansen === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/IdentifiableObjectManager.java 2015-06-16 10:59:33 +0000 @@ -65,25 +65,25 @@ T search( Class clazz, String query ); - Collection filter( Class clazz, String query ); - - Collection getAll( Class clazz ); - - Collection getAllByName( Class clazz, String name ); - - Collection getAllByNameIgnoreCase( Class clazz, String name ); - - Collection getAllSorted( Class clazz ); - - Collection getAllSortedByLastUpdated( Class clazz ); + List filter( Class clazz, String query ); + + List getAll( Class clazz ); + + List getAllByName( Class clazz, String name ); + + List getAllByNameIgnoreCase( Class clazz, String name ); + + List getAllSorted( Class clazz ); + + List getAllSortedByLastUpdated( Class clazz ); List getByUid( Class clazz, Collection uids ); List getByUidOrdered( Class clazz, List uids ); - Collection getLikeName( Class clazz, String name ); + List getLikeName( Class clazz, String name ); - Collection getLikeShortName( Class clazz, String shortName ); + List getLikeShortName( Class clazz, String shortName ); List getBetween( Class clazz, int first, int max ); @@ -95,11 +95,11 @@ List getByLastUpdated( Class clazz, Date lastUpdated ); - Collection getByCreated( Class clazz, Date created ); - - Collection getByLastUpdatedSorted( Class clazz, Date lastUpdated ); - - Collection getByCreatedSorted( Class clazz, Date created ); + List getByCreated( Class clazz, Date created ); + + List getByLastUpdatedSorted( Class clazz, Date lastUpdated ); + + List getByCreatedSorted( Class clazz, Date created ); Date getLastUpdated( Class clazz ); @@ -153,7 +153,7 @@ int getCountNoAcl( Class clazz ); - Collection getAllNoAcl( Class clazz ); + List getAllNoAcl( Class clazz ); - Collection getBetweenNoAcl( Class clazz, int first, int max ); + List getBetweenNoAcl( Class clazz, int first, int max ); } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/IndicatorStore.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/IndicatorStore.java 2015-06-16 05:11:29 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/IndicatorStore.java 2015-06-16 10:59:33 +0000 @@ -28,7 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; import java.util.List; import org.hisp.dhis.common.GenericNameableObjectStore; === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultIdentifiableObjectManager.java 2015-06-16 10:59:33 +0000 @@ -239,7 +239,7 @@ } @Override - public Collection filter( Class clazz, String query ) + public List filter( Class clazz, String query ) { Set uniqueObjects = new HashSet<>(); @@ -268,72 +268,72 @@ @Override @SuppressWarnings( "unchecked" ) - public Collection getAll( Class clazz ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAll(); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getAllByName( Class clazz, String name ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllEqName( name ); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getAllByNameIgnoreCase( Class clazz, String name ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllEqNameIgnoreCase( name ); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getAllSorted( Class clazz ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllOrderedName(); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getAllSortedByLastUpdated( Class clazz ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllOrderedLastUpdated(); + public List getAll( Class clazz ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAll(); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getAllByName( Class clazz, String name ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllEqName( name ); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getAllByNameIgnoreCase( Class clazz, String name ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllEqNameIgnoreCase( name ); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getAllSorted( Class clazz ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllOrderedName(); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getAllSortedByLastUpdated( Class clazz ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllOrderedLastUpdated(); } @Override @@ -472,7 +472,7 @@ @Override @SuppressWarnings( "unchecked" ) - public Collection getLikeName( Class clazz, String name ) + public List getLikeName( Class clazz, String name ) { GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); @@ -481,12 +481,12 @@ return new ArrayList<>(); } - return (Collection) store.getAllLikeName( name ); + return (List) store.getAllLikeName( name ); } @Override @SuppressWarnings( "unchecked" ) - public Collection getLikeShortName( Class clazz, String shortName ) + public List getLikeShortName( Class clazz, String shortName ) { GenericNameableObjectStore store = getNameableObjectStore( clazz ); @@ -495,7 +495,7 @@ return new ArrayList<>(); } - return (Collection) store.getAllLikeShortName( shortName ); + return (List) store.getAllLikeShortName( shortName ); } @Override @@ -570,44 +570,44 @@ @Override @SuppressWarnings( "unchecked" ) - public Collection getByCreated( Class clazz, Date created ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllGeCreated( created ); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getByLastUpdatedSorted( Class clazz, Date lastUpdated ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllGeLastUpdatedOrderedName( lastUpdated ); - } - - @Override - @SuppressWarnings( "unchecked" ) - public Collection getByCreatedSorted( Class clazz, Date created ) - { - GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); - - if ( store == null ) - { - return new ArrayList<>(); - } - - return (Collection) store.getAllGeCreatedOrderedName( created ); + public List getByCreated( Class clazz, Date created ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllGeCreated( created ); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getByLastUpdatedSorted( Class clazz, Date lastUpdated ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllGeLastUpdatedOrderedName( lastUpdated ); + } + + @Override + @SuppressWarnings( "unchecked" ) + public List getByCreatedSorted( Class clazz, Date created ) + { + GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); + + if ( store == null ) + { + return new ArrayList<>(); + } + + return (List) store.getAllGeCreatedOrderedName( created ); } @Override @@ -656,7 +656,7 @@ return map; } - Collection objects = store.getAll(); + List objects = store.getAll(); for ( T object : objects ) { @@ -706,7 +706,7 @@ return map; } - Collection objects = store.getAllNoAcl(); + List objects = store.getAllNoAcl(); for ( T object : objects ) { @@ -760,7 +760,7 @@ GenericNameableObjectStore store = (GenericNameableObjectStore) getNameableObjectStore( clazz ); - Collection objects = store.getAll(); + List objects = store.getAll(); for ( T object : objects ) { @@ -784,7 +784,7 @@ GenericNameableObjectStore store = (GenericNameableObjectStore) getNameableObjectStore( clazz ); - Collection objects = store.getAllNoAcl(); + List objects = store.getAllNoAcl(); for ( T object : objects ) { @@ -926,7 +926,7 @@ @Override @SuppressWarnings( "unchecked" ) - public Collection getAllNoAcl( Class clazz ) + public List getAllNoAcl( Class clazz ) { GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); @@ -935,12 +935,12 @@ return new ArrayList<>(); } - return (Collection) store.getAllNoAcl(); + return (List) store.getAllNoAcl(); } @Override @SuppressWarnings( "unchecked" ) - public Collection getBetweenNoAcl( Class clazz, int first, int max ) + public List getBetweenNoAcl( Class clazz, int first, int max ) { GenericIdentifiableObjectStore store = getIdentifiableObjectStore( clazz ); @@ -949,7 +949,7 @@ return new ArrayList<>(); } - return (Collection) store.getAllNoAcl( first, max ); + return (List) store.getAllNoAcl( first, max ); } @Override === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListAction.java 2015-06-16 10:59:33 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/attribute/GetAttributeListSortOrderAction.java 2015-06-16 10:59:33 +0000 @@ -28,7 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.ArrayList; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionSetListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionSetListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/option/GetOptionSetListAction.java 2015-06-16 10:59:33 +0000 @@ -28,18 +28,17 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import static org.apache.commons.lang3.StringUtils.isNotBlank; + +import java.util.Collections; +import java.util.List; + import org.hisp.dhis.attribute.Attribute; import org.hisp.dhis.common.comparator.IdentifiableObjectNameComparator; import org.hisp.dhis.option.OptionService; import org.hisp.dhis.option.OptionSet; import org.hisp.dhis.paging.ActionPagingSupport; -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; - -import static org.apache.commons.lang3.StringUtils.isNotBlank; - /** * @author Chau Thu Tran * @version $GetOptionSetListAction.java Feb 3, 2012 9:28:11 PM$ === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetCategoryOptionComboListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetCategoryOptionComboListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetCategoryOptionComboListAction.java 2015-06-16 10:59:33 +0000 @@ -28,7 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.ArrayList; import java.util.List; import org.hisp.dhis.dataelement.DataElementCategoryOptionCombo; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryListAction.java 2015-06-16 10:59:33 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryOptionListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryOptionListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/category/GetDataElementCategoryOptionListAction.java 2015-06-16 10:59:33 +0000 @@ -28,15 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import static org.apache.commons.lang3.StringUtils.isNotBlank; + +import java.util.List; + import org.hisp.dhis.dataelement.DataElementCategoryOption; import org.hisp.dhis.dataelement.DataElementCategoryService; import org.hisp.dhis.paging.ActionPagingSupport; -import java.util.ArrayList; -import java.util.List; - -import static org.apache.commons.lang3.StringUtils.isNotBlank; - /** * @author Chau Thu Tran * @version GetDataElementCategoryOptionListAction.java 8:47:42 AM Feb 22, 2013 $ === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/categoryoptiongroup/GetCategoryOptionGroupListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/categoryoptiongroup/GetCategoryOptionGroupListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/categoryoptiongroup/GetCategoryOptionGroupListAction.java 2015-06-16 10:59:33 +0000 @@ -31,7 +31,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; import java.util.ArrayList; -import java.util.Collection; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/indicatortype/GetIndicatorTypeListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/indicatortype/GetIndicatorTypeListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-datadictionary/src/main/java/org/hisp/dhis/dd/action/indicatortype/GetIndicatorTypeListAction.java 2015-06-16 10:59:33 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DataSetListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DataSetListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataset/src/main/java/org/hisp/dhis/dataset/action/DataSetListAction.java 2015-06-16 10:59:33 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List; === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitgroupset/GetGroupSetListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitgroupset/GetGroupSetListAction.java 2015-06-16 10:36:25 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-organisationunit/src/main/java/org/hisp/dhis/oum/action/organisationunitgroupset/GetGroupSetListAction.java 2015-06-16 10:59:33 +0000 @@ -30,7 +30,6 @@ import static org.apache.commons.lang3.StringUtils.isNotBlank; -import java.util.ArrayList; import java.util.Collections; import java.util.List;