=== modified file 'dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/DefaultResourceTableService.java' --- dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/DefaultResourceTableService.java 2014-10-22 15:41:27 +0000 +++ dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/DefaultResourceTableService.java 2014-10-23 09:29:17 +0000 @@ -33,6 +33,7 @@ import static org.hisp.dhis.resourcetable.ResourceTableStore.TABLE_NAME_DATE_PERIOD_STRUCTURE; import static org.hisp.dhis.resourcetable.ResourceTableStore.TABLE_NAME_ORGANISATION_UNIT_STRUCTURE; import static org.hisp.dhis.resourcetable.ResourceTableStore.TABLE_NAME_PERIOD_STRUCTURE; +import static org.hisp.dhis.dataapproval.DataApprovalLevelService.APPROVAL_LEVEL_UNAPPROVED; import java.util.ArrayList; import java.util.Collection; @@ -387,7 +388,7 @@ values.add( dataSet != null ? dataSet.getId() : null ); values.add( dataSet != null ? dataSet.getUid() : null ); values.add( dataSet != null ? dataSet.getName() : null ); - values.add( dataSet != null ? dataSet.isApproveData() : false ); + values.add( dataSet != null && dataSet.isApproveData() ? APPROVAL_LEVEL_UNAPPROVED : 0 ); values.add( periodType != null ? periodType.getId() : null ); values.add( periodType != null ? periodType.getName() : null ); === modified file 'dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/jdbc/JdbcResourceTableStore.java' --- dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/jdbc/JdbcResourceTableStore.java 2014-10-20 15:07:35 +0000 +++ dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/resourcetable/jdbc/JdbcResourceTableStore.java 2014-10-23 09:29:17 +0000 @@ -424,7 +424,7 @@ "datasetid INTEGER, " + "datasetuid CHARACTER(11), " + "datasetname VARCHAR(250), " + - "datasetapprovedata BOOLEAN, " + + "datasetapprovallevel INTEGER, " + "periodtypeid INTEGER, " + "periodtypename VARCHAR(250) )"; @@ -435,13 +435,11 @@ final String deUdInSql = "create unique index in_dataelementstructure_dataelementuid on _dataelementstructure(dataelementuid)"; final String dsIdInSql = "create index in_dataelementstructure_datasetid on _dataelementstructure(datasetid)"; final String dsUdInSql = "create index in_dataelementstructure_datasetuid on _dataelementstructure(datasetuid)"; - final String dsApInSql = "create index in_dataelementstructure_datasetapprovedata on _dataelementstructure(datasetapprovedata)"; final String ptIdInSql = "create index in_dataelementstructure_periodtypeid on _dataelementstructure(periodtypeid)"; jdbcTemplate.execute( deUdInSql ); jdbcTemplate.execute( dsIdInSql ); jdbcTemplate.execute( dsUdInSql ); - jdbcTemplate.execute( dsApInSql ); jdbcTemplate.execute( ptIdInSql ); } === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcAnalyticsTableManager.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcAnalyticsTableManager.java 2014-10-22 19:16:54 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/table/JdbcAnalyticsTableManager.java 2014-10-23 09:29:17 +0000 @@ -28,7 +28,6 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import static org.hisp.dhis.dataapproval.DataApprovalLevelService.APPROVAL_LEVEL_UNAPPROVED; import static org.hisp.dhis.system.util.TextUtils.getQuotedCommaDelimitedString; import java.util.ArrayList; @@ -235,12 +234,11 @@ private String getApprovalSubquery() { String sql = "(" + - "select coalesce(min(dal.level)," + APPROVAL_LEVEL_UNAPPROVED + ") " + + "select coalesce(min(dal.level), des.datasetapprovallevel) " + "from dataapproval da " + "inner join dataapprovallevel dal on da.dataapprovallevelid = dal.dataapprovallevelid " + "where da.periodid = dv.periodid " + "and des.datasetid = da.datasetid " + - "and des.datasetapprovedata = true " + "and ("; Set levels = dataApprovalLevelService.getOrganisationUnitApprovalLevels();