=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/programindicator/GetProgramIndicatorAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/programindicator/GetProgramIndicatorAction.java 2015-06-03 14:47:49 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/java/org/hisp/dhis/trackedentity/action/programindicator/GetProgramIndicatorAction.java 2015-06-03 16:14:07 +0000 @@ -140,20 +140,22 @@ if ( id != null ) { programIndicator = programIndicatorService.getProgramIndicator( id ); + program = programIndicator.getProgram(); description = programIndicatorService.getExpressionDescription( programIndicator.getExpression() ); filter = programIndicatorService.getExpressionDescription( programIndicator.getFilter() ); + attributes = new ArrayList<>( program.getTrackedEntityAttributes() ); } - - if ( programId != null ) + else if ( programId != null ) { program = programService.getProgram( programId ); attributes = new ArrayList<>( program.getTrackedEntityAttributes() ); - constants = new ArrayList<>( constantService.getAllConstants() ); + } + + constants = new ArrayList<>( constantService.getAllConstants() ); - FilterUtils.filter( attributes, AggregatableTrackedEntityAttributeValueFilter.INSTANCE ); - Collections.sort( attributes, IdentifiableObjectNameComparator.INSTANCE ); - Collections.sort( constants, IdentifiableObjectNameComparator.INSTANCE ); - } + FilterUtils.filter( attributes, AggregatableTrackedEntityAttributeValueFilter.INSTANCE ); + Collections.sort( attributes, IdentifiableObjectNameComparator.INSTANCE ); + Collections.sort( constants, IdentifiableObjectNameComparator.INSTANCE ); return SUCCESS; } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/javascript/programIndicator.js' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/javascript/programIndicator.js 2015-06-03 14:47:49 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/javascript/programIndicator.js 2015-06-03 16:14:07 +0000 @@ -10,7 +10,7 @@ // ----------------------------------------------------------------------------- function showUpdateProgramIndicator( context ) { - location.href = 'showUpdateProgramIndicator.action?id=' + context.id + '&programId=' + context.program; + location.href = 'showUpdateProgramIndicator.action?id=' + context.id; } function removeIndicator( context ) { @@ -133,11 +133,9 @@ expression: expression }, function( json ) { if( json.valid ){ - setFieldValue(type + '-check', json.message); setInnerHTML(type + '-description', json.description); } else { - setFieldValue(type + '-check',''); setInnerHTML(type + '-description', json.message); } }); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/programIndicator.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/programIndicator.vm 2015-06-03 14:47:49 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-program/src/main/webapp/dhis-web-maintenance-program/programIndicator.vm 2015-06-03 16:14:07 +0000 @@ -35,8 +35,7 @@
#set( $mark = false ) #foreach( $programIndicator in $programIndicators ) -