=== modified file 'dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetIndicatorsAction.java' --- dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetIndicatorsAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-commons/src/main/java/org/hisp/dhis/commons/action/GetIndicatorsAction.java 2013-10-02 11:32:10 +0000 @@ -28,11 +28,8 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.ArrayList; -import java.util.Collections; -import java.util.List; - import org.apache.struts2.ServletActionContext; +import org.hisp.dhis.common.IdentifiableObjectUtils; import org.hisp.dhis.common.comparator.IdentifiableObjectNameComparator; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; @@ -41,7 +38,10 @@ import org.hisp.dhis.indicator.IndicatorService; import org.hisp.dhis.paging.ActionPagingSupport; import org.hisp.dhis.util.ContextUtils; -import org.hisp.dhis.common.IdentifiableObjectUtils; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; /** * @author Lars Helge Overland @@ -129,7 +129,7 @@ else { indicators = new ArrayList( indicatorService.getAllIndicators() ); - + ContextUtils.clearIfNotModified( ServletActionContext.getRequest(), ServletActionContext.getResponse(), indicators ); } @@ -138,6 +138,11 @@ indicators = IdentifiableObjectUtils.filterNameByKey( indicators, key, true ); } + if ( indicators == null ) + { + indicators = new ArrayList(); + } + Collections.sort( indicators, IdentifiableObjectNameComparator.INSTANCE ); if ( usePaging )