=== modified file 'dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/caseaggregation/DefaultCaseAggregationConditionService.java' --- dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/caseaggregation/DefaultCaseAggregationConditionService.java 2011-07-07 03:34:52 +0000 +++ dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/caseaggregation/DefaultCaseAggregationConditionService.java 2011-07-07 08:03:22 +0000 @@ -259,6 +259,12 @@ int categoryOptionId = Integer.parseInt( ids[2] ); DataElementCategoryOptionCombo optionCombo = categoryService.getDataElementCategoryOptionCombo( categoryOptionId ); + if( programStage == null || dataElement == null || optionCombo == null ) + { + return "Invalid condition"; + + } + matcher.appendReplacement( decription, "[" + programStage.getName() + SEPARATOR_ID + dataElement.getName() + optionCombo.getName() + "]" ); } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/java/org/hisp/dhis/patient/action/validation/GetProgramValidationAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/java/org/hisp/dhis/patient/action/validation/GetProgramValidationAction.java 2011-04-29 07:41:04 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/java/org/hisp/dhis/patient/action/validation/GetProgramValidationAction.java 2011-07-07 08:03:22 +0000 @@ -27,6 +27,7 @@ package org.hisp.dhis.patient.action.validation; +import org.hisp.dhis.caseaggregation.CaseAggregationConditionService; import org.hisp.dhis.program.ProgramValidation; import org.hisp.dhis.program.ProgramValidationService; @@ -45,6 +46,8 @@ private ProgramValidationService programValidationService; + private CaseAggregationConditionService aggregationConditionService; + // ------------------------------------------------------------------------- // Input && Output // ------------------------------------------------------------------------- @@ -53,6 +56,20 @@ private ProgramValidation validation; + private String leftDescription; + + public String getLeftDescription() + { + return leftDescription; + } + + private String rightDescription; + + public String getRightDescription() + { + return rightDescription; + } + // ------------------------------------------------------------------------- // Getter && Setter // ------------------------------------------------------------------------- @@ -62,6 +79,11 @@ this.programValidationService = programValidationService; } + public void setAggregationConditionService( CaseAggregationConditionService aggregationConditionService ) + { + this.aggregationConditionService = aggregationConditionService; + } + public void setValidationId( Integer validationId ) { this.validationId = validationId; @@ -82,6 +104,9 @@ { validation = programValidationService.getProgramValidation( validationId ); + leftDescription = aggregationConditionService.getConditionDescription( validation.getLeftSide() ); + rightDescription = aggregationConditionService.getConditionDescription( validation.getRightSide() ); + return SUCCESS; } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/resources/META-INF/dhis/beans.xml' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/resources/META-INF/dhis/beans.xml 2011-07-07 05:00:40 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/resources/META-INF/dhis/beans.xml 2011-07-07 08:03:22 +0000 @@ -1221,6 +1221,9 @@ + + +

$i18n.getString( "add_program_validation" )

@@ -25,50 +26,61 @@ - -
+ + + + + + + -
- -
- - - -
- - - -
- + + #foreach($stage in $program.programStages) + #end - -
- -
- - -
- + - - - - - + + + + + + + + + + + + + + + + +
+ $i18n.getString( "description" ) +
+
+ + +
+ $i18n.getString( "description" ) +
+
+ + === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/javascript/programValidation.js' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/javascript/programValidation.js 2011-04-29 07:41:04 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/javascript/programValidation.js 2011-07-07 08:03:22 +0000 @@ -8,7 +8,11 @@ if( isSingle || getFieldValue('rightSide') == '1==1') { - hideById('rightSideDiv'); + hideById('rightLabel'); + hideById('rightStage'); + hideById('rightSideDE'); + hideById('rightSide'); + hideById('rightStageDescriptionFieldset'); setFieldValue('rightSide','1==1'); } }); @@ -49,11 +53,24 @@ // Insert items data-element //----------------------------------------------------------------- -function insertDataElement( element, target ) +function insertDataElement( element, target, decriptionDiv ) { byId(target).value += " " + element.options[element.selectedIndex].value + " "; + + getValidationDescription( decriptionDiv, target ); } +function getValidationDescription( decriptionDiv, sideDiv ) +{ + $.post("getCaseAggregationDescription.action", + { + condition: getFieldValue( sideDiv ) + }, + function (data) + { + byId( decriptionDiv ).innerHTML = data; + },'html'); +} //------------------------------------------------------------------------------ // Get DataElements of Program-Stage into left-side === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/programValidationList.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/programValidationList.vm 2011-04-29 07:41:04 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/programValidationList.vm 2011-07-07 08:03:22 +0000 @@ -8,7 +8,7 @@ - + @@ -24,7 +24,7 @@ $validation.description - + $i18n.getString( $i18n.getString( $i18n.getString( @@ -45,8 +45,8 @@



-


-


+


+


=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/responseProgramValidation.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/responseProgramValidation.vm 2011-04-29 07:41:04 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/responseProgramValidation.vm 2011-07-07 08:03:22 +0000 @@ -4,5 +4,5 @@ $encoder.htmlEncode($validation.description) $encoder.htmlEncode($validation.leftSide) $encoder.htmlEncode($validation.rightSide) - $encoder.htmlEncode($validation.rightSide.name) + $encoder.htmlEncode($validation.program.name) \ No newline at end of file === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/updateProgramValidationForm.vm' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/updateProgramValidationForm.vm 2011-04-29 07:41:04 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-patient/src/main/webapp/dhis-web-maintenance-patient/updateProgramValidationForm.vm 2011-07-07 08:03:22 +0000 @@ -24,43 +24,62 @@ - -
+ + + + + + + -
+ + + + + + + -
- - - - -
- - -
- -
- -
- - -
- - - + + + + + + + + + + + + + + + +
+ $i18n.getString( "description" ) +
$!leftDescription
+
+ + +
+ $i18n.getString( "description" ) +
$!rightDescription
+
+ +