=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseIdentifiableObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseIdentifiableObject.java 2013-09-26 07:38:27 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseIdentifiableObject.java 2013-10-01 08:54:05 +0000 @@ -28,6 +28,20 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import java.util.Collection; +import java.util.Date; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Map; +import java.util.Set; + +import org.apache.commons.lang.Validate; +import org.hisp.dhis.common.view.SharingBasicView; +import org.hisp.dhis.common.view.SharingDetailedView; +import org.hisp.dhis.common.view.SharingExportView; +import org.hisp.dhis.user.User; +import org.hisp.dhis.user.UserGroupAccess; + import com.fasterxml.jackson.annotation.JsonIgnore; import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.annotation.JsonView; @@ -35,20 +49,6 @@ import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlElementWrapper; import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlProperty; import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; -import org.apache.commons.lang.Validate; -import org.hisp.dhis.common.view.DetailedView; -import org.hisp.dhis.common.view.SharingBasicView; -import org.hisp.dhis.common.view.SharingDetailedView; -import org.hisp.dhis.common.view.SharingExportView; -import org.hisp.dhis.user.User; -import org.hisp.dhis.user.UserGroupAccess; - -import java.util.Collection; -import java.util.Date; -import java.util.HashMap; -import java.util.HashSet; -import java.util.Map; -import java.util.Set; /** * @author Bob Jolliffe === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/Period.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/Period.java 2013-08-23 15:56:19 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/Period.java 2013-10-01 08:54:05 +0000 @@ -167,17 +167,6 @@ } /** - * Generates an String which uniquely identifies this Period based on its - * core properties. - * - * @return an identifier String. - */ - public String getExternalId() - { - return periodType.getName() + SEPARATOR + getMediumDateString( startDate ) + SEPARATOR + getMediumDateString( endDate ); - } - - /** * Returns the frequency order of the period type of the period. * * @return the frequency order. === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/PeriodService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/PeriodService.java 2013-09-27 12:55:38 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/PeriodService.java 2013-10-01 08:54:05 +0000 @@ -115,16 +115,6 @@ Collection getPeriods( Collection identifiers ); /** - * Generates the Period with the corresponding external identifier. If the - * Period doesn't exist it will be created and persisted. - * - * @param externalId the external identifier. - * @return a Period. - */ - @Deprecated - Period getPeriodByExternalId( String externalId ); - - /** * Returns all Periods with start date after or equal the specified start * date and end date before or equal the specified end date. * === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/period/DefaultPeriodService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/period/DefaultPeriodService.java 2013-09-27 12:55:38 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/period/DefaultPeriodService.java 2013-10-01 08:54:05 +0000 @@ -120,12 +120,6 @@ } ); } - @Deprecated - public Period getPeriodByExternalId( String externalId ) - { - return periodStore.reloadForceAddPeriod( new Period( externalId ) ); - } - public Collection getPeriodsByPeriodType( PeriodType periodType ) { return periodStore.getPeriodsByPeriodType( periodType );