=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java'
--- dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java 2011-09-06 11:52:18 +0000
+++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java 2011-09-24 11:35:11 +0000
@@ -55,16 +55,12 @@
private String numeratorDescription;
- private String numeratorAggregationOperator;
-
private String explodedNumerator;
private String denominator;
private String denominatorDescription;
- private String denominatorAggregationOperator;
-
private String explodedDenominator;
private Integer sortOrder;
@@ -202,16 +198,6 @@
this.numeratorDescription = numeratorDescription;
}
- public String getNumeratorAggregationOperator()
- {
- return numeratorAggregationOperator;
- }
-
- public void setNumeratorAggregationOperator( String numeratorAggregationOperator )
- {
- this.numeratorAggregationOperator = numeratorAggregationOperator;
- }
-
public String getExplodedNumerator()
{
return explodedNumerator;
@@ -242,16 +228,6 @@
this.denominatorDescription = denominatorDescription;
}
- public String getDenominatorAggregationOperator()
- {
- return denominatorAggregationOperator;
- }
-
- public void setDenominatorAggregationOperator( String denominatorAggregationOperator )
- {
- this.denominatorAggregationOperator = denominatorAggregationOperator;
- }
-
public String getExplodedDenominator()
{
return explodedDenominator;
=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java'
--- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2011-09-16 04:30:16 +0000
+++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2011-09-24 11:35:11 +0000
@@ -103,7 +103,9 @@
executeSql( "ALTER TABLE section DROP COLUMN label" );
executeSql( "ALTER TABLE section DROP COLUMN title" );
executeSql( "ALTER TABLE organisationunit DROP COLUMN polygoncoordinates" );
- executeSql( "ALTER TABLE dataelementcategory DROP COLUMN conceptName" );
+ executeSql( "ALTER TABLE indicator DROP COLUMN extendeddataelementid" );
+ executeSql( "ALTER TABLE indicator DROP COLUMN numeratoraggregationtype" );
+ executeSql( "ALTER TABLE indicator DROP COLUMN denominatoraggregationtype" );
// remove relative period type
executeSql( "DELETE FROM period WHERE periodtypeid=(select periodtypeid from periodtype where name='Relative')" );
=== modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml'
--- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml 2011-09-21 14:43:36 +0000
+++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml 2011-09-24 11:35:11 +0000
@@ -43,14 +43,10 @@
-
-
-
-
=== modified file 'dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceMultiDimensionTest.java'
--- dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceMultiDimensionTest.java 2010-12-07 17:02:27 +0000
+++ dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceMultiDimensionTest.java 2011-09-24 11:35:11 +0000
@@ -484,10 +484,8 @@
String suffixB = Expression.SEPARATOR + categoryOptionComboB.getId();
indicatorA.setNumerator( "[" + dataElementA.getId() + suffixA + "]*[" + dataElementA.getId() + suffixB + "]" );
- indicatorA.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorA.setDenominator( "1" );
- indicatorA.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorIds.add( indicatorService.addIndicator( indicatorA ) );
@@ -546,18 +544,14 @@
String suffixB = Expression.SEPARATOR + categoryOptionComboB.getId();
indicatorA.setNumerator( "[" + dataElementA.getId() + suffixA + "]+[" + dataElementA.getId() + suffixB + "]" );
- indicatorA.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorA.setDenominator( "100" );
- indicatorA.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
Indicator indicatorB = createIndicator( 'B', indicatorType );
indicatorB.setNumerator( "[" + dataElementA.getId() + "]" );
- indicatorB.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorB.setDenominator( "100" );
- indicatorB.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorIds.add( indicatorService.addIndicator( indicatorA ) );
indicatorIds.add( indicatorService.addIndicator( indicatorB ) );
@@ -631,10 +625,8 @@
String suffixB = Expression.SEPARATOR + categoryOptionComboB.getId();
indicatorA.setNumerator( "[" + dataElementA.getId() + suffixA + "]*[" + dataElementA.getId() + suffixB + "]" );
- indicatorA.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorA.setDenominator( "1" );
- indicatorA.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorIds.add( indicatorService.addIndicator( indicatorA ) );
=== modified file 'dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceTest.java'
--- dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceTest.java 2011-04-24 15:50:02 +0000
+++ dhis-2/dhis-services/dhis-service-datamart-default/src/test/java/org/hisp/dhis/datamart/DataMartServiceTest.java 2011-09-24 11:35:11 +0000
@@ -460,10 +460,8 @@
String suffix = "." + categoryOptionCombo.getId();
indicatorA.setNumerator( "[" + idC + suffix + "]*[" + idD + suffix + "]" );
- indicatorA.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorA.setDenominator( "[" + idE + suffix + "]+[" + idF + suffix + "]" );
- indicatorA.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_AVERAGE );
indicatorIds.add( indicatorService.addIndicator( indicatorA ) );
@@ -548,10 +546,8 @@
String suffix = Expression.SEPARATOR + categoryOptionCombo.getId();
indicatorA.setNumerator( "[" + idC + suffix + "]*[" + idD + suffix + "]" );
- indicatorA.setNumeratorAggregationOperator( DataElement.AGGREGATION_OPERATOR_SUM );
indicatorA.setDenominator( "[" + idE + suffix + "]+[" + idF + suffix + "]" );
- indicatorA.setDenominatorAggregationOperator( DataElement.AGGREGATION_OPERATOR_AVERAGE );
indicatorIds.add( indicatorService.addIndicator( indicatorA ) );
=== modified file 'dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/IndicatorRowHandler.java'
--- dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/IndicatorRowHandler.java 2010-05-29 16:06:56 +0000
+++ dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/IndicatorRowHandler.java 2011-09-24 11:35:11 +0000
@@ -27,9 +27,7 @@
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-import static org.hisp.dhis.dataelement.DataElement.AGGREGATION_OPERATOR_SUM;
import static org.hisp.dhis.importexport.dhis14.util.Dhis14ExpressionConverter.convertExpressionFromDhis14;
-import static org.hisp.dhis.importexport.dhis14.util.Dhis14ExpressionConverter.getFirstDataElementId;
import java.util.Map;
@@ -39,7 +37,6 @@
import org.hisp.dhis.importexport.ImportParams;
import org.hisp.dhis.importexport.analysis.ImportAnalyser;
import org.hisp.dhis.importexport.importer.IndicatorImporter;
-import org.hisp.dhis.importexport.mapping.NameMappingUtil;
import org.hisp.dhis.indicator.Indicator;
import org.hisp.dhis.indicator.IndicatorService;
import org.hisp.dhis.system.util.UUIdUtils;
@@ -57,8 +54,6 @@
private Map