=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataintegrity/DataIntegrityService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataintegrity/DataIntegrityService.java 2010-04-12 21:23:33 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataintegrity/DataIntegrityService.java 2010-05-20 09:54:45 +0000 @@ -28,7 +28,7 @@ */ import java.util.Collection; -import java.util.Map; +import java.util.SortedMap; import org.hisp.dhis.dataelement.DataElement; import org.hisp.dhis.dataset.DataSet; @@ -67,7 +67,7 @@ * Returns all data elements which are members of data sets with different * period types. */ - Map> getDataElementsAssignedToDataSetsWithDifferentPeriodTypes(); + SortedMap> getDataElementsAssignedToDataSetsWithDifferentPeriodTypes(); // ------------------------------------------------------------------------- // DataSet @@ -95,12 +95,12 @@ /** * Gets all indicators with invalid indicator numerators. */ - Map getInvalidIndicatorNumerators(); + SortedMap getInvalidIndicatorNumerators(); /** * Gets all indicators with invalid indicator denominators. */ - Map getInvalidIndicatorDenominators(); + SortedMap getInvalidIndicatorDenominators(); // ------------------------------------------------------------------------- // OrganisationUnit @@ -154,10 +154,10 @@ /** * Gets all ValidationRules with invalid left side expressions. */ - Map getInvalidValidationRuleLeftSideExpressions(); + SortedMap getInvalidValidationRuleLeftSideExpressions(); /** * Gets all ValidationRules with invalid right side expressions. */ - Map getInvalidValidationRuleRightSideExpressions(); + SortedMap getInvalidValidationRuleRightSideExpressions(); } === modified file 'dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/dataintegrity/DefaultDataIntegrityService.java' --- dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/dataintegrity/DefaultDataIntegrityService.java 2010-04-12 21:23:33 +0000 +++ dhis-2/dhis-services/dhis-service-administration/src/main/java/org/hisp/dhis/dataintegrity/DefaultDataIntegrityService.java 2010-05-20 09:54:45 +0000 @@ -31,19 +31,21 @@ import java.util.ArrayList; import java.util.Collection; -import java.util.HashMap; import java.util.HashSet; import java.util.Hashtable; -import java.util.Map; import java.util.Set; +import java.util.SortedMap; +import java.util.TreeMap; import org.hisp.dhis.dataelement.DataElement; import org.hisp.dhis.dataelement.DataElementService; +import org.hisp.dhis.dataelement.comparator.DataElementNameComparator; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.expression.ExpressionService; import org.hisp.dhis.indicator.Indicator; import org.hisp.dhis.indicator.IndicatorService; +import org.hisp.dhis.indicator.comparator.IndicatorNameComparator; import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.organisationunit.OrganisationUnitGroup; import org.hisp.dhis.organisationunit.OrganisationUnitGroupService; @@ -56,6 +58,7 @@ import org.hisp.dhis.system.util.FilterUtils; import org.hisp.dhis.validation.ValidationRule; import org.hisp.dhis.validation.ValidationRuleService; +import org.hisp.dhis.validation.comparator.ValidationRuleNameComparator; import org.springframework.transaction.annotation.Transactional; import org.springframework.util.CollectionUtils; @@ -141,13 +144,13 @@ return dataElementService.getDataElementsWithoutGroups(); } - public Map> getDataElementsAssignedToDataSetsWithDifferentPeriodTypes() + public SortedMap> getDataElementsAssignedToDataSetsWithDifferentPeriodTypes() { Collection dataElements = dataElementService.getAllDataElements(); Collection dataSets = dataSetService.getAllDataSets(); - Map> targets = new HashMap>(); + SortedMap> targets = new TreeMap>( new DataElementNameComparator() ); for ( DataElement element : dataElements ) { @@ -236,9 +239,9 @@ return indicatorService.getIndicatorsWithoutGroups(); } - public Map getInvalidIndicatorNumerators() + public SortedMap getInvalidIndicatorNumerators() { - Map invalids = new HashMap(); + SortedMap invalids = new TreeMap( new IndicatorNameComparator() ); for ( Indicator indicator : indicatorService.getAllIndicators() ) { @@ -253,9 +256,9 @@ return invalids; } - public Map getInvalidIndicatorDenominators() + public SortedMap getInvalidIndicatorDenominators() { - Map invalids = new HashMap(); + SortedMap invalids = new TreeMap( new IndicatorNameComparator() ); for ( Indicator indicator : indicatorService.getAllIndicators() ) { @@ -395,9 +398,9 @@ } ); } - public Map getInvalidValidationRuleLeftSideExpressions() + public SortedMap getInvalidValidationRuleLeftSideExpressions() { - Map invalids = new HashMap(); + SortedMap invalids = new TreeMap( new ValidationRuleNameComparator() ); for ( ValidationRule rule : validationRuleService.getAllValidationRules() ) { @@ -412,9 +415,9 @@ return invalids; } - public Map getInvalidValidationRuleRightSideExpressions() + public SortedMap getInvalidValidationRuleRightSideExpressions() { - Map invalids = new HashMap(); + SortedMap invalids = new TreeMap( new ValidationRuleNameComparator() ); for ( ValidationRule rule : validationRuleService.getAllValidationRules() ) {