=== added file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/comparator/IdentifiableObjectCodeComparator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/comparator/IdentifiableObjectCodeComparator.java 1970-01-01 00:00:00 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/comparator/IdentifiableObjectCodeComparator.java 2013-01-30 20:37:26 +0000 @@ -0,0 +1,51 @@ +package org.hisp.dhis.common.comparator; + +/* + * Copyright (c) 2004-2012, University of Oslo + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * * Neither the name of the HISP project nor the names of its contributors may + * be used to endorse or promote products derived from this software without + * specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +import java.util.Comparator; + +import org.hisp.dhis.common.IdentifiableObject; + +/** + * @author Lars Helge Overland + */ +public class IdentifiableObjectCodeComparator + implements Comparator +{ + public static final Comparator INSTANCE = new IdentifiableObjectCodeComparator(); + + public int compare( IdentifiableObject object0, IdentifiableObject object1 ) + { + if ( object0 == null ) + { + return object1 == null ? 0 : -1; + } + + return object1 == null ? 1 : object0.getCode().compareToIgnoreCase( object1.getCode() ); + } +} === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2013-01-30 13:46:01 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultAnalyticsService.java 2013-01-30 20:37:26 +0000 @@ -98,6 +98,7 @@ //TODO completeness //TODO make sure data x dims are successive + //TODO disable all dim options? often leads to sequential scans @Autowired private AnalyticsManager analyticsManager; === modified file 'dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultQueryPlanner.java' --- dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultQueryPlanner.java 2013-01-28 12:50:32 +0000 +++ dhis-2/dhis-services/dhis-service-analytics/src/main/java/org/hisp/dhis/analytics/data/DefaultQueryPlanner.java 2013-01-30 20:37:26 +0000 @@ -312,7 +312,8 @@ * meaningful to split on multiple data element group sets. * * If the aggregation type is already set/overridden in the request, the - * query will be returned unchanged. + * query will be returned unchanged. If there are no dimension options specified + * the aggregation type will fall back to sum. */ private List groupByAggregationType( DataQueryParams params ) { @@ -337,11 +338,15 @@ query.setAggregationType( aggregationType ); queries.add( query ); } + + return queries; } - else if ( params.getDataElementGroupSets() != null && !params.getDataElementGroupSets().isEmpty() ) + + Dimension groupSet = null; + + if ( params.getDataElementGroupSets() != null && !params.getDataElementGroupSets().isEmpty() && + ( groupSet = params.getDataElementGroupSets().iterator().next() ).getOptions() != null && !groupSet.getOptions().isEmpty() ) { - Dimension groupSet = params.getDataElementGroupSets().iterator().next(); - PeriodType periodType = PeriodType.getPeriodTypeByName( params.getPeriodType() ); ListMap aggregationTypeDataElementGroupMap = getAggregationTypeDataElementGroupMap( groupSet.getOptions(), periodType ); @@ -353,12 +358,13 @@ query.setAggregationType( aggregationType ); queries.add( query ); } - } - else - { - queries.add( new DataQueryParams( params ) ); + + return queries; } + DataQueryParams query = new DataQueryParams( params ); + query.setAggregationType( SUM ); + queries.add( query ); return queries; }