=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/AddSqlViewAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/AddSqlViewAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/AddSqlViewAction.java 2013-10-02 13:21:01 +0000 @@ -27,11 +27,11 @@ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ + +import com.opensymphony.xwork2.Action; import org.hisp.dhis.sqlview.SqlView; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * @author Dang Duy Hieu * @version $Id AddSqlViewAction.java July 06, 2010$ === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/CheckViewTableExistenceAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/CheckViewTableExistenceAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/CheckViewTableExistenceAction.java 2013-10-02 13:21:01 +0000 @@ -28,16 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; import org.hisp.dhis.i18n.I18n; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * Updates a existing sqlview in database. - * + * * @author Dang Duy Hieu - * @version $Id CheckViewTableExistenceAction.java July 16, 2010$ */ public class CheckViewTableExistenceAction implements Action @@ -112,5 +110,4 @@ return SUCCESS; } - } === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExecuteSqlViewQueryAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExecuteSqlViewQueryAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExecuteSqlViewQueryAction.java 2013-10-02 13:21:01 +0000 @@ -28,17 +28,15 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; import org.hisp.dhis.i18n.I18n; import org.hisp.dhis.sqlview.SqlView; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * Updates a existing sqlview to the database. - * + * * @author Dang Duy Hieu - * @version $Id ExecuteSqlViewQueryAction.java July 06, 2010$ */ public class ExecuteSqlViewQueryAction implements Action @@ -97,7 +95,7 @@ } SqlView sqlViewInstance = sqlViewService.getSqlView( id ); - + String viewName = sqlViewInstance.getViewName(); message = sqlViewService.createViewTable( sqlViewInstance ); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExportSqlViewResultAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExportSqlViewResultAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ExportSqlViewResultAction.java 2013-10-02 13:21:01 +0000 @@ -37,7 +37,6 @@ * Updates a existing sqlview in database. * * @author Dang Duy Hieu - * @version $Id ExportSqlViewResultAction.java July 12, 2010$ */ public class ExportSqlViewResultAction extends ActionPagingSupport === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewListAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewListAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewListAction.java 2013-10-02 13:21:01 +0000 @@ -28,17 +28,15 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; +import org.hisp.dhis.sqlview.SqlView; +import org.hisp.dhis.sqlview.SqlViewService; + import java.util.ArrayList; import java.util.List; -import org.hisp.dhis.sqlview.SqlView; -import org.hisp.dhis.sqlview.SqlViewService; - -import com.opensymphony.xwork2.Action; - /** * @author Dang Duy Hieu - * @version $Id GetSqlViewListAction.java July 10, 2010$ */ public class GetSqlViewListAction implements Action === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewObjectAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewObjectAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/GetSqlViewObjectAction.java 2013-10-02 13:21:01 +0000 @@ -28,16 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; import org.hisp.dhis.sqlview.SqlView; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * Removes a existing regular expression from the database. - * + * * @author Dang Duy Hieu - * @version $Id GetSqlViewObjectAction.java July 06, 2010$ */ public class GetSqlViewObjectAction implements Action === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/RemoveSqlViewAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/RemoveSqlViewAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/RemoveSqlViewAction.java 2013-10-02 13:21:01 +0000 @@ -28,15 +28,13 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * Removes a existing regular expression from the database. - * + * * @author Dang Duy Hieu - * @version $Id RemoveSqlViewAction.java July 06, 2010$ */ public class RemoveSqlViewAction implements Action @@ -44,7 +42,7 @@ // ------------------------------------------------------------------------- // Dependencies // ------------------------------------------------------------------------- - + private SqlViewService sqlViewService; public void setSqlViewService( SqlViewService sqlViewService ) === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/UpdateSqlViewAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/UpdateSqlViewAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/UpdateSqlViewAction.java 2013-10-02 13:21:01 +0000 @@ -28,16 +28,14 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import com.opensymphony.xwork2.Action; import org.hisp.dhis.sqlview.SqlView; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; - /** * Updates a existing sqlview in database. - * + * * @author Dang Duy Hieu - * @version $Id UpdateSqlViewAction.java July 06, 2010$ */ public class UpdateSqlViewAction implements Action === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java 2013-08-23 16:05:01 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/sqlview/ValidateAddUpdateSqlViewAction.java 2013-10-02 13:21:01 +0000 @@ -28,18 +28,16 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import static org.hisp.dhis.sqlview.ResourceTableNameMap.getIgnoredNameMap; - -import java.util.Map; - +import com.opensymphony.xwork2.Action; import org.hisp.dhis.i18n.I18n; import org.hisp.dhis.sqlview.SqlViewService; -import com.opensymphony.xwork2.Action; +import java.util.Map; + +import static org.hisp.dhis.sqlview.ResourceTableNameMap.getIgnoredNameMap; /** * @author Dang Duy Hieu - * @version $Id ValidateAddUpdateSqlViewAction.java July 07, 2010$ */ public class ValidateAddUpdateSqlViewAction implements Action @@ -47,13 +45,13 @@ private static final String ADD = "add"; private static final String SEMICOLON = ";"; - + private static final String SEPERATE = "|"; - + private static final String SPACE = " "; private static final String INTO = " into "; - + private static final String REGEX_SELECT_QUERY = "^(?i)\\s*select\\s{1,}.+$"; private static final String PREFIX_REGEX_IGNORE_TABLES_QUERY = "^(?i).+((?<=[^\\d\\w])("; @@ -148,7 +146,7 @@ } final String ignoredRegex = this.setUpIgnoredRegex(); - + sqlquery = sqlViewService.makeUpForQueryStatement( sqlquery ); for ( String s : sqlquery.split( SEMICOLON ) ) @@ -185,19 +183,19 @@ // ------------------------------------------------------------------------- private String setUpIgnoredRegex() - { + { int i = 0; int len = getIgnoredNameMap().size(); - + StringBuffer ignoredRegex = new StringBuffer( PREFIX_REGEX_IGNORE_TABLES_QUERY ); for ( Map.Entry entry : getIgnoredNameMap().entrySet() ) - { + { ignoredRegex.append( entry.getValue() ); - + if ( ++i < len ) { - ignoredRegex.append( SEPERATE ); + ignoredRegex.append( SEPERATE ); } }