=== modified file 'dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/hibernate/HibernatePatientStore.java' --- dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/hibernate/HibernatePatientStore.java 2013-10-11 06:11:27 +0000 +++ dhis-2/dhis-services/dhis-service-patient/src/main/java/org/hisp/dhis/patient/hibernate/HibernatePatientStore.java 2013-10-11 08:27:42 +0000 @@ -28,6 +28,8 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import org.apache.commons.logging.Log; +import org.apache.commons.logging.LogFactory; import org.hibernate.Criteria; import org.hibernate.Query; import org.hibernate.criterion.Conjunction; @@ -69,6 +71,8 @@ extends HibernateIdentifiableObjectStore implements PatientStore { + private static final Log log = LogFactory.getLog( HibernatePatientStore.class ); + // ------------------------------------------------------------------------- // Dependencies // ------------------------------------------------------------------------- @@ -349,14 +353,13 @@ } @Override - @SuppressWarnings( "deprecation" ) public int countGetPatientsByOrgUnitProgram( OrganisationUnit organisationUnit, Program program ) { String sql = "select count(p.patientid) from patient p join programinstance pi on p.patientid=pi.patientid " + "where p.organisationunitid=" + organisationUnit.getId() + " and pi.programid=" + program.getId() + " and pi.status=" + ProgramInstance.STATUS_ACTIVE; - return jdbcTemplate.queryForInt( sql ); + return jdbcTemplate.queryForObject( sql, Integer.class ); } @Override @@ -842,6 +845,8 @@ sql += statementBuilder.limitRecord( min, max ); } + log.debug( "Search patient SQL: " + sql ); + return sql; } === modified file 'dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/StatementBuilder.java' --- dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/StatementBuilder.java 2013-10-11 08:07:20 +0000 +++ dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/StatementBuilder.java 2013-10-11 08:27:42 +0000 @@ -78,11 +78,11 @@ /** * Returns a limit and offset clause. * + * @param offset the offset / start position for the records to return. * @param limit the limit on max number of records to return. - * @param offset the offset for the records to return. * @return a limit and offset clause. */ - String limitRecord( int limit, int offset ); + String limitRecord( int offset, int limit ); /** * Returns statement for vacuum and analyze operations for a table. Returns === modified file 'dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/statementbuilder/AbstractStatementBuilder.java' --- dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/statementbuilder/AbstractStatementBuilder.java 2013-10-11 08:07:20 +0000 +++ dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/statementbuilder/AbstractStatementBuilder.java 2013-10-11 08:27:42 +0000 @@ -63,7 +63,7 @@ } @Override - public String limitRecord( int limit, int offset ) + public String limitRecord( int offset, int limit ) { return " LIMIT " + limit + " OFFSET " + offset; }