=== modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/dataintegrity/GetDataIntegrityAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/dataintegrity/GetDataIntegrityAction.java 2010-04-12 21:23:33 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-dataadmin/src/main/java/org/hisp/dhis/dataadmin/action/dataintegrity/GetDataIntegrityAction.java 2010-05-20 09:16:11 +0000 @@ -27,16 +27,25 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import java.util.ArrayList; import java.util.Collection; +import java.util.Collections; +import java.util.List; import java.util.Map; import org.hisp.dhis.dataelement.DataElement; +import org.hisp.dhis.dataelement.comparator.DataElementNameComparator; import org.hisp.dhis.dataintegrity.DataIntegrityService; import org.hisp.dhis.dataset.DataSet; +import org.hisp.dhis.dataset.comparator.DataSetNameComparator; import org.hisp.dhis.indicator.Indicator; +import org.hisp.dhis.indicator.comparator.IndicatorNameComparator; import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.organisationunit.OrganisationUnitGroup; +import org.hisp.dhis.organisationunit.comparator.OrganisationUnitGroupNameComparator; +import org.hisp.dhis.organisationunit.comparator.OrganisationUnitNameComparator; import org.hisp.dhis.validation.ValidationRule; +import org.hisp.dhis.validation.comparator.ValidationRuleNameComparator; import com.opensymphony.xwork2.Action; @@ -62,23 +71,23 @@ // Output // ------------------------------------------------------------------------- - private Collection dataElementsWithoutDataSet; + private List dataElementsWithoutDataSet; - public Collection getDataElementsWithoutDataSet() + public List getDataElementsWithoutDataSet() { return dataElementsWithoutDataSet; } - private Collection dataElementsWithoutGroups; + private List dataElementsWithoutGroups; public Collection getDataElementsWithoutGroups() { return dataElementsWithoutGroups; } - private Collection dataSetsNotAssignedToOrganisationUnits; + private List dataSetsNotAssignedToOrganisationUnits; - public Collection getDataSetsNotAssignedToOrganisationUnits() + public List getDataSetsNotAssignedToOrganisationUnits() { return dataSetsNotAssignedToOrganisationUnits; } @@ -97,9 +106,9 @@ return indicatorsWithIdenticalFormulas; } - private Collection indicatorsWithoutGroups; + private List indicatorsWithoutGroups; - public Collection getIndicatorsWithoutGroups() + public List getIndicatorsWithoutGroups() { return indicatorsWithoutGroups; } @@ -118,51 +127,51 @@ return invalidIndicatorDenominators; } - private Collection organisationUnitsWithCyclicReferences; + private List organisationUnitsWithCyclicReferences; - public Collection getOrganisationUnitsWithCyclicReferences() + public List getOrganisationUnitsWithCyclicReferences() { return organisationUnitsWithCyclicReferences; } - private Collection orphanedOrganisationUnits; + private List orphanedOrganisationUnits; - public Collection getOrphanedOrganisationUnits() + public List getOrphanedOrganisationUnits() { return orphanedOrganisationUnits; } - private Collection organisationUnitsWithoutGroups; + private List organisationUnitsWithoutGroups; - public Collection getOrganisationUnitsWithoutGroups() + public List getOrganisationUnitsWithoutGroups() { return organisationUnitsWithoutGroups; } - private Collection organisationUnitsViolatingCompulsoryGroupSets; + private List organisationUnitsViolatingCompulsoryGroupSets; - public Collection getOrganisationUnitsViolatingCompulsoryGroupSets() + public List getOrganisationUnitsViolatingCompulsoryGroupSets() { return organisationUnitsViolatingCompulsoryGroupSets; } - private Collection organisationUnitsViolatingExclusiveGroupSets; + private List organisationUnitsViolatingExclusiveGroupSets; - public Collection getOrganisationUnitsViolatingExclusiveGroupSets() + public List getOrganisationUnitsViolatingExclusiveGroupSets() { return organisationUnitsViolatingExclusiveGroupSets; } - private Collection organisationUnitGroupsWithoutGroupSets; + private List organisationUnitGroupsWithoutGroupSets; - public Collection getOrganisationUnitGroupsWithoutGroupSets() + public List getOrganisationUnitGroupsWithoutGroupSets() { return organisationUnitGroupsWithoutGroupSets; } - private Collection validationRulesWithoutGroups; + private List validationRulesWithoutGroups; - public Collection getValidationRulesWithoutGroups() + public List getValidationRulesWithoutGroups() { return validationRulesWithoutGroups; } @@ -187,29 +196,36 @@ public String execute() { - dataElementsWithoutDataSet = dataIntegrityService.getDataElementsWithoutDataSet(); - dataElementsWithoutGroups = dataIntegrityService.getDataElementsWithoutGroups(); - dataElementsAssignedToDataSetsWithDifferentPeriodTypes = dataIntegrityService.getDataElementsAssignedToDataSetsWithDifferentPeriodTypes(); - - dataSetsNotAssignedToOrganisationUnits = dataIntegrityService.getDataSetsNotAssignedToOrganisationUnits(); - + dataElementsWithoutDataSet = new ArrayList( dataIntegrityService.getDataElementsWithoutDataSet() ); + dataElementsWithoutGroups = new ArrayList( dataIntegrityService.getDataElementsWithoutGroups() ); + dataElementsAssignedToDataSetsWithDifferentPeriodTypes = dataIntegrityService.getDataElementsAssignedToDataSetsWithDifferentPeriodTypes(); + dataSetsNotAssignedToOrganisationUnits = new ArrayList( dataIntegrityService.getDataSetsNotAssignedToOrganisationUnits() ); indicatorsWithIdenticalFormulas = dataIntegrityService.getIndicatorsWithIdenticalFormulas(); - indicatorsWithoutGroups = dataIntegrityService.getIndicatorsWithoutGroups(); + indicatorsWithoutGroups = new ArrayList( dataIntegrityService.getIndicatorsWithoutGroups() ); invalidIndicatorNumerators = dataIntegrityService.getInvalidIndicatorNumerators(); - invalidIndicatorDenominators = dataIntegrityService.getInvalidIndicatorDenominators(); - - organisationUnitsWithCyclicReferences = dataIntegrityService.getOrganisationUnitsWithCyclicReferences(); - orphanedOrganisationUnits = dataIntegrityService.getOrphanedOrganisationUnits(); - organisationUnitsWithoutGroups = dataIntegrityService.getOrganisationUnitsWithoutGroups(); - organisationUnitsViolatingCompulsoryGroupSets = dataIntegrityService.getOrganisationUnitsViolatingCompulsoryGroupSets(); - organisationUnitsViolatingExclusiveGroupSets = dataIntegrityService.getOrganisationUnitsViolatingExclusiveGroupSets(); - - organisationUnitGroupsWithoutGroupSets = dataIntegrityService.getOrganisationUnitGroupsWithoutGroupSets(); - - validationRulesWithoutGroups = dataIntegrityService.getValidationRulesWithoutGroups(); + invalidIndicatorDenominators = dataIntegrityService.getInvalidIndicatorDenominators(); + organisationUnitsWithCyclicReferences = new ArrayList( dataIntegrityService.getOrganisationUnitsWithCyclicReferences() ); + orphanedOrganisationUnits = new ArrayList( dataIntegrityService.getOrphanedOrganisationUnits() ); + organisationUnitsWithoutGroups = new ArrayList( dataIntegrityService.getOrganisationUnitsWithoutGroups() ); + organisationUnitsViolatingCompulsoryGroupSets = new ArrayList( dataIntegrityService.getOrganisationUnitsViolatingCompulsoryGroupSets() ); + organisationUnitsViolatingExclusiveGroupSets = new ArrayList( dataIntegrityService.getOrganisationUnitsViolatingExclusiveGroupSets() ); + organisationUnitGroupsWithoutGroupSets = new ArrayList( dataIntegrityService.getOrganisationUnitGroupsWithoutGroupSets() ); + validationRulesWithoutGroups = new ArrayList( dataIntegrityService.getValidationRulesWithoutGroups() ); invalidValidationRuleLeftSideExpressions = dataIntegrityService.getInvalidValidationRuleLeftSideExpressions(); invalidValidationRuleRightSideExpressions = dataIntegrityService.getInvalidValidationRuleRightSideExpressions(); + Collections.sort( dataElementsWithoutDataSet, new DataElementNameComparator() ); + Collections.sort( dataElementsWithoutGroups, new DataElementNameComparator() ); + Collections.sort( dataSetsNotAssignedToOrganisationUnits, new DataSetNameComparator() ); + Collections.sort( indicatorsWithoutGroups, new IndicatorNameComparator() ); + Collections.sort( organisationUnitsWithCyclicReferences, new OrganisationUnitNameComparator() ); + Collections.sort( orphanedOrganisationUnits, new OrganisationUnitNameComparator() ); + Collections.sort( organisationUnitsWithoutGroups, new OrganisationUnitNameComparator() ); + Collections.sort( organisationUnitsViolatingCompulsoryGroupSets, new OrganisationUnitNameComparator() ); + Collections.sort( organisationUnitsViolatingExclusiveGroupSets, new OrganisationUnitNameComparator() ); + Collections.sort( organisationUnitGroupsWithoutGroupSets, new OrganisationUnitGroupNameComparator() ); + Collections.sort( validationRulesWithoutGroups, new ValidationRuleNameComparator() ); + return SUCCESS; } }