=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/RelativePeriods.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/RelativePeriods.java 2012-07-23 16:26:34 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/period/RelativePeriods.java 2012-07-23 17:00:59 +0000 @@ -348,27 +348,25 @@ * Gets the PeriodType with the highest frequency from a list of Periods. */ public PeriodType getHighestFrequencyPeriodType( List periods ) - { + { + PeriodType periodType = null; + if ( periods != null ) { - PeriodType periodType = periods.get( 0 ).getPeriodType(); - - int lowestFrequencyOrder = periodType.getFrequencyOrder(); + PeriodType lowestFrequencyOrder = periods.get( 0 ).getPeriodType(); for ( Period period : periods ) { - if ( period.getPeriodType().getFrequencyOrder() < lowestFrequencyOrder ) + if ( period.getPeriodType().getFrequencyOrder() < lowestFrequencyOrder.getFrequencyOrder() ) { - lowestFrequencyOrder = period.getPeriodType().getFrequencyOrder(); - - periodType = period.getPeriodType(); + lowestFrequencyOrder = period.getPeriodType(); } } - return periodType; + return lowestFrequencyOrder; } - return null; + return periodType; } /**