=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java 2013-05-08 22:56:40 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/BaseDimensionalObject.java 2013-05-10 08:28:01 +0000 @@ -44,7 +44,16 @@ public class BaseDimensionalObject extends BaseIdentifiableObject implements DimensionalObject { + /** + * The dimensional items for this dimension. + */ private List items = new ArrayList(); + + /** + * Indicates whether this object should be considered a data dimension. Assumes + * true by default. + */ + private boolean dataDimension = true; public BaseDimensionalObject() { @@ -85,4 +94,14 @@ { this.items = items; } + + public boolean isDataDimension() + { + return dataDimension; + } + + public void setDataDimension( boolean dataDimension ) + { + this.dataDimension = dataDimension; + } } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2013-05-08 22:56:40 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/common/DimensionalObject.java 2013-05-10 08:28:01 +0000 @@ -49,4 +49,6 @@ String getDimension(); List getItems(); + + boolean isDataDimension(); } === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java 2013-05-08 22:56:40 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElementCategory.java 2013-05-10 08:28:01 +0000 @@ -67,8 +67,6 @@ public static final String DEFAULT_NAME = "default"; - private boolean dataDimension; - private Concept concept; @Scanned @@ -213,19 +211,6 @@ // ------------------------------------------------------------------------ @JsonProperty - @JsonView( { DetailedView.class, ExportView.class } ) - @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) - public boolean isDataDimension() - { - return dataDimension; - } - - public void setDataDimension( boolean dataDimension ) - { - this.dataDimension = dataDimension; - } - - @JsonProperty @JsonSerialize( contentAs = BaseIdentifiableObject.class ) @JsonView( {DetailedView.class, ExportView.class} ) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultDimensionService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultDimensionService.java 2013-05-08 22:56:40 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/common/DefaultDimensionService.java 2013-05-10 08:28:01 +0000 @@ -34,6 +34,7 @@ import java.util.Map; import org.hisp.dhis.dataelement.DataElementCategory; +import org.hisp.dhis.dataelement.DataElementCategoryService; import org.hisp.dhis.dataelement.DataElementGroupSet; import org.hisp.dhis.organisationunit.OrganisationUnitGroupSet; import org.springframework.beans.factory.annotation.Autowired; @@ -47,6 +48,9 @@ @Autowired private IdentifiableObjectManager identifiableObjectManager; + @Autowired + private DataElementCategoryService categoryService; + @Override public DimensionalObject getDimension( String uid ) { @@ -115,7 +119,7 @@ { Collection degs = identifiableObjectManager.getAll( DataElementGroupSet.class ); Collection ougs = identifiableObjectManager.getAll( OrganisationUnitGroupSet.class ); - Collection dcs = identifiableObjectManager.getAll( DataElementCategory.class ); + Collection dcs = categoryService.getDataDimensionDataElementCategories(); final List dimensions = new ArrayList();