=== modified file 'dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/AddValidationRuleGroupAction.java' --- dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/AddValidationRuleGroupAction.java 2013-09-27 17:05:36 +0000 +++ dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/AddValidationRuleGroupAction.java 2013-10-13 18:20:54 +0000 @@ -28,7 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; +import java.util.Set; import org.hisp.dhis.user.UserService; import org.hisp.dhis.validation.ValidationRuleGroup; @@ -79,20 +79,20 @@ this.description = description; } - private Collection groupMembers; + private Set groupMembers; - public void setGroupMembers( Collection groupMembers ) + public void setGroupMembers( Set groupMembers ) { this.groupMembers = groupMembers; } - private Collection selectedUserRolesToAlert; + private Set userRolesToAlert; + + public void setUserRolesToAlert( Set userRolesToAlert ) + { + this.userRolesToAlert = userRolesToAlert; + } - public void setSelectedUserRolesToAlert( Collection selectedUserRolesToAlert ) - { - this.selectedUserRolesToAlert = selectedUserRolesToAlert; - } - // ------------------------------------------------------------------------- // Action implementation // ------------------------------------------------------------------------- @@ -113,9 +113,9 @@ } group.getUserAuthorityGroupsToAlert().clear(); - if ( selectedUserRolesToAlert != null ) + if ( userRolesToAlert != null ) { - for ( String id : selectedUserRolesToAlert ) + for ( String id : userRolesToAlert ) { group.getUserAuthorityGroupsToAlert().add( userService.getUserAuthorityGroup( Integer.valueOf( id ) ) ); } === modified file 'dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/ShowUpdateValidationRuleGroupFormAction.java' --- dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/ShowUpdateValidationRuleGroupFormAction.java 2013-10-08 19:10:40 +0000 +++ dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/ShowUpdateValidationRuleGroupFormAction.java 2013-10-13 18:20:54 +0000 @@ -90,6 +90,13 @@ return validationRuleGroup; } + private List availableValidationRules = new ArrayList(); + + public List getAvailableValidationRules() + { + return availableValidationRules; + } + private List groupMembers = new ArrayList(); public List getGroupMembers() @@ -97,13 +104,6 @@ return groupMembers; } - private List availableValidationRules = new ArrayList(); - - public List getAvailableValidationRules() - { - return availableValidationRules; - } - private List availableUserRolesToAlert = new ArrayList(); public List getAvailableUserRolesToAlert() @@ -111,11 +111,11 @@ return availableUserRolesToAlert; } - private List selectedUserRolesToAlert = new ArrayList(); - - public List getSelectedUserRolesToAlert() + private List userRolesToAlert = new ArrayList(); + + public List getUserRolesToAlert() { - return selectedUserRolesToAlert; + return userRolesToAlert; } // ------------------------------------------------------------------------- @@ -124,10 +124,6 @@ public String execute() { - // --------------------------------------------------------------------- - // Get selected group - // --------------------------------------------------------------------- - validationRuleGroup = validationRuleService.getValidationRuleGroup( id, true ); groupMembers = new ArrayList( validationRuleGroup.getMembers() ); @@ -136,11 +132,10 @@ availableUserRolesToAlert = new ArrayList( userService.getAllUserAuthorityGroups() ); - selectedUserRolesToAlert = new ArrayList( validationRuleGroup.getUserAuthorityGroupsToAlert() ); + userRolesToAlert = new ArrayList( validationRuleGroup.getUserAuthorityGroupsToAlert() ); - Collections.sort( selectedUserRolesToAlert, IdentifiableObjectNameComparator.INSTANCE ); + Collections.sort( userRolesToAlert, IdentifiableObjectNameComparator.INSTANCE ); return SUCCESS; } - } === modified file 'dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/UpdateValidationRuleGroupAction.java' --- dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/UpdateValidationRuleGroupAction.java 2013-10-08 19:10:40 +0000 +++ dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/validationrulegroup/UpdateValidationRuleGroupAction.java 2013-10-13 18:20:54 +0000 @@ -28,7 +28,7 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ -import java.util.Collection; +import java.util.Set; import org.hisp.dhis.user.UserService; import org.hisp.dhis.validation.ValidationRuleGroup; @@ -86,20 +86,20 @@ this.description = description; } - private Collection groupMembers; + private Set groupMembers; - public void setGroupMembers( Collection groupMembers ) + public void setGroupMembers( Set groupMembers ) { this.groupMembers = groupMembers; } - private Collection selectedUserRolesToAlert; + private Set userRolesToAlert; + + public void setUserRolesToAlert( Set userRolesToAlert ) + { + this.userRolesToAlert = userRolesToAlert; + } - public void setSelectedUserRolesToAlert( Collection selectedUserRolesToAlert ) - { - this.selectedUserRolesToAlert = selectedUserRolesToAlert; - } - // ------------------------------------------------------------------------- // Action implementation // ------------------------------------------------------------------------- @@ -122,9 +122,9 @@ group.getUserAuthorityGroupsToAlert().clear(); - if ( selectedUserRolesToAlert != null ) + if ( userRolesToAlert != null ) { - for ( String id : selectedUserRolesToAlert ) + for ( String id : userRolesToAlert ) { group.getUserAuthorityGroupsToAlert().add( userService.getUserAuthorityGroup( Integer.valueOf( id ) ) ); } === modified file 'dhis-2/dhis-web/dhis-web-validationrule/src/main/webapp/dhis-web-validationrule/addValidationRuleGroupForm.vm' --- dhis-2/dhis-web/dhis-web-validationrule/src/main/webapp/dhis-web-validationrule/addValidationRuleGroupForm.vm 2013-10-08 19:10:40 +0000 +++ dhis-2/dhis-web/dhis-web-validationrule/src/main/webapp/dhis-web-validationrule/addValidationRuleGroupForm.vm 2013-10-13 18:20:54 +0000 @@ -15,7 +15,7 @@ jQuery("#availableUserRolesToAlert").dhisAjaxSelect({ source: "../dhis-web-commons-ajax-json/getUserRoles.action", iterator: "userRoles", - connectedTo: 'selectedUserRolesToAlert', + connectedTo: 'userRolesToAlert', handler: function(item) { var option = jQuery(" #end