=== modified file 'dhis-2/dhis-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java' --- dhis-2/dhis-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java 2012-06-04 13:02:01 +0000 +++ dhis-2/dhis-dxf2/src/main/java/org/hisp/dhis/dxf2/metadata/importers/DefaultIdentifiableObjectImporter.java 2012-06-04 13:38:24 +0000 @@ -753,15 +753,8 @@ if ( objects != null && !objects.isEmpty() ) { collectionFields.put( field, objects ); - - if ( List.class.isAssignableFrom( field.getType() ) ) - { - ReflectionUtils.invokeSetterMethod( field.getName(), object, new ArrayList() ); - } - else if ( Set.class.isAssignableFrom( field.getType() ) ) - { - ReflectionUtils.invokeSetterMethod( field.getName(), object, new HashSet() ); - } + Collection emptyCollection = ReflectionUtils.newCollectionInstance( field.getType() ); + ReflectionUtils.invokeSetterMethod( field.getName(), object, emptyCollection ); } } } ); @@ -776,21 +769,7 @@ for ( Field field : collectionFields.keySet() ) { Collection collection = collectionFields.get( field ); - Collection objects; - - if ( List.class.isAssignableFrom( field.getType() ) ) - { - objects = new ArrayList(); - } - else if ( Set.class.isAssignableFrom( field.getType() ) ) - { - objects = new HashSet(); - } - else - { - log.warn( "Unknown Collection type." ); - continue; - } + Collection objects = ReflectionUtils.newCollectionInstance( field.getType() ); for ( Object idObject : collection ) { === modified file 'dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/util/ReflectionUtils.java' --- dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/util/ReflectionUtils.java 2012-06-04 13:02:01 +0000 +++ dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/util/ReflectionUtils.java 2012-06-04 13:38:24 +0000 @@ -35,10 +35,7 @@ import java.lang.annotation.Annotation; import java.lang.reflect.*; -import java.util.ArrayList; -import java.util.Arrays; -import java.util.Collection; -import java.util.List; +import java.util.*; /** * @author Lars Helge Overland @@ -456,4 +453,20 @@ return fields; } + + public static Collection newCollectionInstance( Class clazz ) + { + if ( List.class.isAssignableFrom( clazz ) ) + { + return new ArrayList(); + } + else if ( Set.class.isAssignableFrom( clazz ) ) + { + return new HashSet(); + } + else + { + throw new RuntimeException( "Unknown Collection type." ); + } + } }