=== modified file 'dhis-2/dhis-services/dhis-service-datamart-default/src/main/java/org/hisp/dhis/datamart/crosstab/jdbc/JDBCCrossTabStore.java' --- dhis-2/dhis-services/dhis-service-datamart-default/src/main/java/org/hisp/dhis/datamart/crosstab/jdbc/JDBCCrossTabStore.java 2011-04-19 07:06:57 +0000 +++ dhis-2/dhis-services/dhis-service-datamart-default/src/main/java/org/hisp/dhis/datamart/crosstab/jdbc/JDBCCrossTabStore.java 2011-06-02 12:50:56 +0000 @@ -64,52 +64,26 @@ public void createCrossTabTable( final Collection operands, String key ) { - final StatementHolder holder = statementManager.getHolder(); - - try - { - final StringBuffer sql = new StringBuffer( "CREATE TABLE " + TABLE_PREFIX + key + " ( " ); - - sql.append( "periodid INTEGER NOT NULL, " ); - sql.append( "sourceid INTEGER NOT NULL, " ); - - for ( DataElementOperand operand : operands ) - { - sql.append( operand.getColumnName() ).append( " VARCHAR(30), " ); - } - - sql.append( "PRIMARY KEY ( periodid, sourceid ) );" ); - - holder.getStatement().executeUpdate( sql.toString() ); - } - catch ( SQLException ex ) - { - throw new RuntimeException( "Failed to create datavalue crosstab table", ex ); - } - finally - { - holder.close(); - } + final StringBuffer sql = new StringBuffer( "CREATE TABLE " + TABLE_PREFIX + key + " ( " ); + + sql.append( "periodid INTEGER NOT NULL, " ); + sql.append( "sourceid INTEGER NOT NULL, " ); + + for ( DataElementOperand operand : operands ) + { + sql.append( operand.getColumnName() ).append( " VARCHAR(30), " ); + } + + sql.append( "PRIMARY KEY ( periodid, sourceid ) );" ); + + statementManager.getHolder().executeUpdate( sql.toString() ); } public void dropCrossTabTable( String key ) { - final StatementHolder holder = statementManager.getHolder(); + final String sql = "DROP TABLE IF EXISTS " + TABLE_PREFIX + key; - try - { - final String sql = "DROP TABLE IF EXISTS " + TABLE_PREFIX + key; - - holder.getStatement().executeUpdate( sql ); - } - catch ( SQLException ex ) - { - throw new RuntimeException( "Failed to drop datavalue crosstab table", ex ); - } - finally - { - holder.close(); - } + statementManager.getHolder().executeUpdate( sql ); } // -------------------------------------------------------------------------