=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataanalysis/DataAnalysisStore.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataanalysis/DataAnalysisStore.java 2009-12-23 17:34:18 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataanalysis/DataAnalysisStore.java 2009-12-23 18:43:20 +0000 @@ -34,7 +34,6 @@ import org.hisp.dhis.datavalue.DeflatedDataValue; import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.period.Period; -import org.hisp.dhis.period.PeriodType; /** * @author Lars Helge Overland @@ -46,5 +45,5 @@ Double getAverage( DataElement dataElement, DataElementCategoryOptionCombo categoryOptionCombo, OrganisationUnit organisationUnit ); Collection getDeflatedDataValues( DataElement dataElement, DataElementCategoryOptionCombo categoryOptionCombo, - Collection periods, OrganisationUnit organisationUnit, PeriodType periodType, int lowerBound, int upperBound ); + Collection periods, OrganisationUnit organisationUnit, int lowerBound, int upperBound ); } === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/MinMaxOutlierAnalysisService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/MinMaxOutlierAnalysisService.java 2009-12-23 18:11:28 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/MinMaxOutlierAnalysisService.java 2009-12-23 18:43:20 +0000 @@ -115,7 +115,7 @@ if ( minMaxDataElement != null ) { return dataAnalysisStore.getDeflatedDataValues( dataElement, categoryOptionCombo, periods, - organisationUnit, dataElement.getPeriodType(), minMaxDataElement.getMin(), minMaxDataElement.getMax() ); + organisationUnit, minMaxDataElement.getMin(), minMaxDataElement.getMax() ); } return new ArrayList(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/StdDevOutlierAnalysisService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/StdDevOutlierAnalysisService.java 2009-12-23 18:12:39 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/StdDevOutlierAnalysisService.java 2009-12-23 18:43:20 +0000 @@ -112,7 +112,7 @@ Double upperBound = avg + deviation; return dataAnalysisStore.getDeflatedDataValues( dataElement, categoryOptionCombo, periods, - organisationUnit, dataElement.getPeriodType(), lowerBound.intValue(), upperBound.intValue() ); + organisationUnit, lowerBound.intValue(), upperBound.intValue() ); } return new ArrayList(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/jdbc/JdbcDataAnalysisStore.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/jdbc/JdbcDataAnalysisStore.java 2009-12-23 17:34:18 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataanalysis/jdbc/JdbcDataAnalysisStore.java 2009-12-23 18:43:20 +0000 @@ -41,7 +41,6 @@ import org.hisp.dhis.jdbc.StatementBuilder; import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.period.Period; -import org.hisp.dhis.period.PeriodType; import org.hisp.dhis.system.objectmapper.DeflatedDataValueNameMinMaxRowMapper; import org.hisp.dhis.system.util.ConversionUtils; import org.hisp.dhis.system.util.TextUtils; @@ -97,7 +96,7 @@ } public Collection getDeflatedDataValues( DataElement dataElement, DataElementCategoryOptionCombo categoryOptionCombo, - Collection periods, OrganisationUnit organisationUnit, PeriodType periodType, int lowerBound, int upperBound ) + Collection periods, OrganisationUnit organisationUnit, int lowerBound, int upperBound ) { final StatementHolder holder = statementManager.getHolder(); @@ -121,7 +120,7 @@ "WHERE dv.dataelementid='" + dataElement.getId() + "' " + "AND dv.categoryoptioncomboid='" + categoryOptionCombo.getId() + "' " + "AND dv.periodid IN (" + periodIds + ") " + - "AND pt.periodtypeid='" + periodType.getId() + "' " + + "AND pt.periodtypeid='" + dataElement.getPeriodType().getId() + "' " + "AND dv.sourceid='" + organisationUnit.getId() + "' " + "AND ( CAST( dv.value AS " + statementBuilder.getDoubleColumnType() + " ) < '" + lowerBound + "' " + "OR CAST( dv.value AS " + statementBuilder.getDoubleColumnType() + " ) > '" + upperBound + "' )";