=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2012-12-08 16:07:13 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2013-02-03 10:44:42 +0000 @@ -67,6 +67,7 @@ public static final String TYPE_DEFAULT = "default"; public static final String TYPE_SECTION = "section"; public static final String TYPE_CUSTOM = "custom"; + public static final String TYPE_SECTION_MULTIORG = "multiorg_section"; public static final int NO_EXPIRY = 0; === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/DefaultDataElementService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/DefaultDataElementService.java 2013-01-28 08:50:29 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/dataelement/DefaultDataElementService.java 2013-02-03 10:44:42 +0000 @@ -261,14 +261,14 @@ public List getDataElementCategoryCombos( List dataElements ) { - Set setCategoryCombos = new HashSet(); + Set categoryCombos = new HashSet(); for ( DataElement dataElement : dataElements ) { - setCategoryCombos.add( dataElement.getCategoryCombo() ); + categoryCombos.add( dataElement.getCategoryCombo() ); } - List listCategoryCombos = new ArrayList( setCategoryCombos ); + List listCategoryCombos = new ArrayList( categoryCombos ); Collections.sort( listCategoryCombos, new DataElementCategoryComboSizeComparator() ); === modified file 'dhis-2/dhis-web/dhis-web-dataentry/src/main/java/org/hisp/dhis/de/action/LoadFormAction.java' --- dhis-2/dhis-web/dhis-web-dataentry/src/main/java/org/hisp/dhis/de/action/LoadFormAction.java 2013-01-28 08:50:29 +0000 +++ dhis-2/dhis-web/dhis-web-dataentry/src/main/java/org/hisp/dhis/de/action/LoadFormAction.java 2013-02-03 10:44:42 +0000 @@ -88,17 +88,6 @@ } // ------------------------------------------------------------------------- - // Comparator - // ------------------------------------------------------------------------- - - private Comparator dataElementComparator; - - public void setDataElementComparator( Comparator dataElementComparator ) - { - this.dataElementComparator = dataElementComparator; - } - - // ------------------------------------------------------------------------- // Input // ------------------------------------------------------------------------- @@ -235,7 +224,7 @@ return INPUT; } - Collections.sort( dataElements, dataElementComparator ); + Collections.sort( dataElements, IdentifiableObjectNameComparator.INSTANCE ); orderedDataElements = dataElementService.getGroupedDataElementsByCategoryCombo( dataElements ); @@ -307,13 +296,11 @@ String displayMode = dataSet.getDataSetType(); - if ( multiOrganisationUnit != null && multiOrganisationUnit != 0 ) // for - // multiOrg, - // we - // only - // support - // section - // forms + // --------------------------------------------------------------------- + // For multi-org unit we only support custom forms + // --------------------------------------------------------------------- + + if ( multiOrganisationUnit != null && multiOrganisationUnit != 0 ) { OrganisationUnit organisationUnit = organisationUnitService.getOrganisationUnit( multiOrganisationUnit ); List organisationUnitChildren = new ArrayList(); @@ -336,7 +323,8 @@ organisationUnits.addAll( organisationUnitChildren ); getSectionForm( dataElements, dataSet ); - displayMode = "multiorg_section"; + + displayMode = DataSet.TYPE_SECTION_MULTIORG; } if ( displayMode.equals( DataSet.TYPE_SECTION ) ) { @@ -403,6 +391,5 @@ orderedDataElements.put( categoryCombo, des ); } - } }