=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/user/UserService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/user/UserService.java 2013-08-23 15:56:19 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/user/UserService.java 2013-09-13 12:12:02 +0000 @@ -353,6 +353,8 @@ * @return a Collection of UserSettings. */ Collection getAllUserSettings( User user ); + + Collection getUserSettings( String name ); /** * Deletes a UserSetting. === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/DefaultUserService.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/DefaultUserService.java 2013-09-13 11:31:15 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/DefaultUserService.java 2013-09-13 12:12:02 +0000 @@ -498,6 +498,11 @@ { return userCredentialsStore.getAllUserSettings( user ); } + + public Collection getUserSettings( String name ) + { + return userCredentialsStore.getUserSettings( name ); + } public UserSetting getUserSetting( User user, String name ) { === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/UserSettingDeletionHandler.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/UserSettingDeletionHandler.java 2013-09-13 11:31:15 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/user/UserSettingDeletionHandler.java 2013-09-13 12:12:02 +0000 @@ -30,6 +30,7 @@ import org.hisp.dhis.datadictionary.DataDictionary; import org.hisp.dhis.system.deletion.DeletionHandler; +import org.springframework.beans.factory.annotation.Autowired; /** * @author Lars Helge Overland @@ -44,12 +45,8 @@ // Dependencies // ------------------------------------------------------------------------- - private UserSettingService userSettingService; - - public void setUserSettingService( UserSettingService userSettingService ) - { - this.userSettingService = userSettingService; - } + @Autowired + private UserService userService; // ------------------------------------------------------------------------- // DeletionHandler implementation @@ -64,14 +61,11 @@ @Override public void deleteDataDictionary( DataDictionary dataDictionary ) { - for ( UserSetting setting : userSettingService.getAllUserSettings() ) + for ( UserSetting setting : userService.getUserSettings( SETTING_NAME_DATADICTIONARY ) ) { - if ( setting.getName().equals( SETTING_NAME_DATADICTIONARY ) ) + if ( setting.getValue() != null && (Integer) setting.getValue() == dataDictionary.getId() ) { - if ( setting.getValue() != null && (Integer) setting.getValue() == dataDictionary.getId() ) - { - userSettingService.deleteUserSetting( SETTING_NAME_DATADICTIONARY ); - } + userService.deleteUserSetting( setting ); } } } @@ -79,12 +73,10 @@ @Override public void deleteUser( User user ) { - for ( UserSetting setting : userSettingService.getAllUserSettings() ) + System.out.println("yes"); + for ( UserSetting setting : userService.getAllUserSettings( user ) ) { - if ( setting.getUser() != null && setting.getUser().equals( user ) ) - { - userSettingService.deleteUserSetting( setting.getName() ); - } + userService.deleteUserSetting( setting ); } } } === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/META-INF/dhis/beans.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/META-INF/dhis/beans.xml 2013-09-13 11:31:15 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/META-INF/dhis/beans.xml 2013-09-13 12:12:02 +0000 @@ -1025,9 +1025,7 @@ - - - + === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/pom.xml' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/pom.xml 2013-05-31 08:27:38 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-user/pom.xml 2013-09-13 12:12:02 +0000 @@ -27,6 +27,11 @@ org.hisp.dhis + dhis-service-reporting + + + + org.hisp.dhis dhis-service-core