=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/engine/DefaultDataSetCompletenessEngine.java' --- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/engine/DefaultDataSetCompletenessEngine.java 2012-04-06 20:02:26 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/engine/DefaultDataSetCompletenessEngine.java 2013-01-01 00:28:39 +0000 @@ -48,8 +48,10 @@ import org.hisp.dhis.period.PeriodService; import org.hisp.dhis.period.RelativePeriods; import org.hisp.dhis.setting.SystemSettingManager; +import org.hisp.dhis.system.filter.DataSetWithOrganisationUnitsFilter; import org.hisp.dhis.system.util.ConcurrentUtils; import org.hisp.dhis.system.util.ConversionUtils; +import org.hisp.dhis.system.util.FilterUtils; import org.hisp.dhis.system.util.PaginatedList; import org.hisp.dhis.system.util.SystemUtils; import org.springframework.transaction.annotation.Transactional; @@ -150,6 +152,8 @@ dataSets = completenessStore.getDataSetsWithRegistrations( dataSets ); + FilterUtils.filter( dataSets, new DataSetWithOrganisationUnitsFilter() ); + List> organisationUnitPages = new PaginatedList( organisationUnits ).setNumberOfPages( cpuCores ).getPages(); List> futures = new ArrayList>(); === added file 'dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/filter/DataSetWithOrganisationUnitsFilter.java' --- dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/filter/DataSetWithOrganisationUnitsFilter.java 1970-01-01 00:00:00 +0000 +++ dhis-2/dhis-support/dhis-support-system/src/main/java/org/hisp/dhis/system/filter/DataSetWithOrganisationUnitsFilter.java 2013-01-01 00:28:39 +0000 @@ -0,0 +1,44 @@ +package org.hisp.dhis.system.filter; + +/* + * Copyright (c) 2004-2012, University of Oslo + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * * Neither the name of the HISP project nor the names of its contributors may + * be used to endorse or promote products derived from this software without + * specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ + +import org.hisp.dhis.dataset.DataSet; +import org.hisp.dhis.system.util.Filter; + +/** + * @author Lars Helge Overland + */ +public class DataSetWithOrganisationUnitsFilter + implements Filter +{ + @Override + public boolean retain( DataSet dataSet ) + { + return dataSet != null && dataSet.getSources() != null && dataSet.getSources().size() > 0; + } +}