=== modified file 'dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java' --- dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java 2011-03-01 19:32:40 +0000 +++ dhis-2/dhis-services/dhis-service-reporting/src/main/java/org/hisp/dhis/completeness/impl/AbstractDataSetCompletenessService.java 2011-03-01 19:44:03 +0000 @@ -226,9 +226,9 @@ int days = (Integer) systemSettingManager.getSystemSetting( KEY_COMPLETENESS_OFFSET, DEFAULT_COMPLETENESS_OFFSET ); Date deadline = getDeadline( period, days ); - final Collection children = getIdentifiers( OrganisationUnit.class, organisationUnitService.getOrganisationUnitWithChildren( organisationUnitId ) ); + final Collection children = organisationUnitService.getOrganisationUnitHierarchy().getChildren( organisationUnitId ); - final Collection dataSets = dataSetService.getAllDataSets(); // getDataSetsBySources( children ); TODO fix? + final Collection dataSets = dataSetService.getAllDataSets(); final Collection results = new ArrayList(); @@ -270,11 +270,9 @@ final Collection results = new ArrayList(); - Collection children = null; - for ( final OrganisationUnit unit : units ) { - children = getIdentifiers( OrganisationUnit.class, organisationUnitService.getOrganisationUnitWithChildren( unit.getId() ) ); + final Collection children = organisationUnitService.getOrganisationUnitHierarchy().getChildren( unit.getId() ); final DataSetCompletenessResult result = new DataSetCompletenessResult(); @@ -298,8 +296,8 @@ } public DataSetCompletenessResult getDataSetCompleteness( Period period, Date deadline, OrganisationUnit unit, DataSet dataSet ) - { - final Collection children = getIdentifiers( OrganisationUnit.class, organisationUnitService.getOrganisationUnitWithChildren( unit.getId() ) ); + { + final Collection children = organisationUnitService.getOrganisationUnitHierarchy().getChildren( unit.getId() ); final DataSetCompletenessResult result = new DataSetCompletenessResult();