=== modified file 'dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/controller/FacilityController.java' --- dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/controller/FacilityController.java 2012-12-13 10:55:39 +0000 +++ dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/controller/FacilityController.java 2012-12-18 17:57:10 +0000 @@ -34,6 +34,7 @@ import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.hierarchy.HierarchyViolationException; import org.hisp.dhis.organisationunit.OrganisationUnit; +import org.hisp.dhis.organisationunit.OrganisationUnitLevel; import org.hisp.dhis.organisationunit.OrganisationUnitService; import org.hisp.dhis.user.CurrentUserService; import org.hisp.dhis.web.webapi.v1.domain.Facilities; @@ -293,12 +294,27 @@ } Collections.sort( allOrganisationUnits, IdentifiableObjectNameComparator.INSTANCE ); + List organisationUnitLevels = organisationUnitService.getOrganisationUnitLevels(); for ( OrganisationUnit organisationUnit : allOrganisationUnits ) { Facility facility = conversionService.convert( organisationUnit, Facility.class ); filterFacility( facility, allProperties, fields ); + // TODO this probably belongs in "meta": {} + List> hierarchy = new ArrayList>(); + facility.getProperties().put( "hierarchy", hierarchy ); + + for ( OrganisationUnitLevel organisationUnitLevel : organisationUnitLevels ) + { + Map level = new HashMap(); + + level.put( "name", organisationUnitLevel.getName() ); + level.put( "level", organisationUnitLevel.getLevel() ); + + hierarchy.add( level ); + } + facilities.getFacilities().add( facility ); } === modified file 'dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/utils/OrganisationUnitToFacilityConverter.java' --- dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/utils/OrganisationUnitToFacilityConverter.java 2012-12-13 17:04:35 +0000 +++ dhis-2/dhis-web/dhis-web-api-fred/src/main/java/org/hisp/dhis/web/webapi/v1/utils/OrganisationUnitToFacilityConverter.java 2012-12-18 17:57:10 +0000 @@ -31,7 +31,6 @@ import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.organisationunit.OrganisationUnitLevel; import org.hisp.dhis.organisationunit.OrganisationUnitService; -import org.hisp.dhis.organisationunit.comparator.OrganisationUnitLevelComparator; import org.hisp.dhis.web.webapi.v1.controller.FacilityController; import org.hisp.dhis.web.webapi.v1.domain.Facility; import org.hisp.dhis.web.webapi.v1.domain.Identifier; @@ -40,7 +39,6 @@ import org.springframework.stereotype.Component; import java.util.ArrayList; -import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -111,23 +109,6 @@ facility.getProperties().put( "level", organisationUnit.getOrganisationUnitLevel() ); - List organisationUnitLevels = organisationUnitService.getOrganisationUnitLevels(); - Collections.sort( organisationUnitLevels, new OrganisationUnitLevelComparator() ); - - // TODO this probably belongs in "meta": {} - List> hierarchy = new ArrayList>(); - facility.getProperties().put( "hierarchy", hierarchy ); - - for ( OrganisationUnitLevel organisationUnitLevel : organisationUnitLevels ) - { - Map level = new HashMap(); - - level.put( "name", organisationUnitLevel.getName() ); - level.put( "level", organisationUnitLevel.getLevel() ); - - hierarchy.add( level ); - } - return facility; } }